build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60782 )
Change subject: mb/google/guybrush/var/dewatt: Update unused GPIO pins ......................................................................
Patch Set 1:
(64 comments)
File src/mainboard/google/guybrush/variants/dewatt/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/7b3a79e5_1fd01225 PS1, Line 16: /* Unused TP245*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/09f24414_326500d3 PS1, Line 17: PAD_NC(GPIO_8), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/2850fda4_3c9d2786 PS1, Line 17: PAD_NC(GPIO_8), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/e2323ddb_40b51ced PS1, Line 18: /* Unused TP244*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/53d48e98_7de80966 PS1, Line 19: PAD_NC(GPIO_11), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/05c1951c_f0a707ae PS1, Line 19: PAD_NC(GPIO_11), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/4c80551c_0e36c0e8 PS1, Line 20: /* Unused TP194*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/6b36d475_2079fc19 PS1, Line 21: PAD_NC(GPIO_17), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/5318d598_c91634df PS1, Line 21: PAD_NC(GPIO_17), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/442d999e_5dbf0809 PS1, Line 22: /* Unused TP195*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/4193902b_8eb59818 PS1, Line 23: PAD_NC(GPIO_18), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/00370801_c9067038 PS1, Line 23: PAD_NC(GPIO_18), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/d7e00fb8_26e84c23 PS1, Line 24: /* Unused TP243*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/e6cee913_f0db702f PS1, Line 25: PAD_NC(GPIO_21), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/74dd4b83_277b62f1 PS1, Line 25: PAD_NC(GPIO_21), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/b0915a1e_6f73e633 PS1, Line 26: /* Unused TP196*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/c4691ac5_26ce3c46 PS1, Line 27: PAD_NC(GPIO_24), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/54914735_353177d4 PS1, Line 27: PAD_NC(GPIO_24), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/74af5cc7_1fdb7c7d PS1, Line 28: /* Unused TP219*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/57cd79a1_1d2d52ce PS1, Line 29: PAD_NC(GPIO_42), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/f8257a5f_c15bd676 PS1, Line 29: PAD_NC(GPIO_42), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/fb8ebd1d_4085520b PS1, Line 30: /* Unused TP217*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/6fa59504_a63c4d86 PS1, Line 31: PAD_NC(GPIO_69), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/e951869e_c5ba1890 PS1, Line 31: PAD_NC(GPIO_69), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/3736a799_cd567c77 PS1, Line 32: /* Unused TP235*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/95345ab2_aef20668 PS1, Line 33: PAD_NC(GPIO_115), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/797974b3_d31f1114 PS1, Line 33: PAD_NC(GPIO_115), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/b5c82c4c_b05d65c6 PS1, Line 34: /* Unused TP205*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/55beee4a_37c9e9f6 PS1, Line 35: PAD_NC(GPIO_116), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/030aa0f6_09c506db PS1, Line 35: PAD_NC(GPIO_116), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/9321d866_af4e388d PS1, Line 36: /* Unused TP226*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/439f3b97_af13a639 PS1, Line 37: PAD_NC(GPIO_140), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/6a1f1fdd_926d1f1e PS1, Line 37: PAD_NC(GPIO_140), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/74183878_9db1eaee PS1, Line 38: /* Unused TP225*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/eecf890f_b1ab2de0 PS1, Line 39: PAD_NC(GPIO_142), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/9938228b_2579a084 PS1, Line 39: PAD_NC(GPIO_142), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/c41e1d4f_58a69c18 PS1, Line 40: /* Unused TP227*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/c2c67ba2_bd6aa5ed PS1, Line 41: PAD_NC(GPIO_144), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/d5504d10_adbe479b PS1, Line 41: PAD_NC(GPIO_144), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/9219478a_a13d24aa PS1, Line 45: /* Unused TP245*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/e0ed24b6_c99e57fe PS1, Line 46: PAD_NC(GPIO_8), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/4761a441_bc92a734 PS1, Line 46: PAD_NC(GPIO_8), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/47629668_5a3c637d PS1, Line 47: /* Unused TP195*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/c2905f05_b9cff97d PS1, Line 48: PAD_NC(GPIO_18), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/296b04da_123695f5 PS1, Line 48: PAD_NC(GPIO_18), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/dbbc936d_6da1b31c PS1, Line 49: /* Unused TP196*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/563ea6dd_ee2a7e98 PS1, Line 50: PAD_NC(GPIO_24), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/0a20e155_ac51c3ec PS1, Line 50: PAD_NC(GPIO_24), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/cf57d941_9c294c95 PS1, Line 51: /* Unused TP217*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/f8a11aeb_6d98db39 PS1, Line 52: PAD_NC(GPIO_69), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/3aafb0d5_3fd9ca5f PS1, Line 52: PAD_NC(GPIO_69), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/944a82da_8a97ff8d PS1, Line 57: /* Unused TP195*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/9afbe829_afdb99fe PS1, Line 58: PAD_NC(GPIO_18), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/ccda46f0_28520c29 PS1, Line 58: PAD_NC(GPIO_18), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/800e3513_756f8f56 PS1, Line 59: /* Unused TP217*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/f13d0342_6c4c8a1d PS1, Line 60: PAD_NC(GPIO_69), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/ce909645_a8c18185 PS1, Line 60: PAD_NC(GPIO_69), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/c5a49563_9baaa022 PS1, Line 65: /* Unused TP196*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/bb974ecf_e4024f97 PS1, Line 66: PAD_NC(GPIO_24), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/e9802819_289e6cbf PS1, Line 66: PAD_NC(GPIO_24), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/bb42b3e9_7d21a495 PS1, Line 89: *size = ARRAY_SIZE(bootblock_gpio_table); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/665b79c8_91106f87 PS1, Line 89: *size = ARRAY_SIZE(bootblock_gpio_table); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/70ac9d58_2450b70b PS1, Line 90: return override_bootblock_gpio_table; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137305): https://review.coreboot.org/c/coreboot/+/60782/comment/d92866a0_1ce4b983 PS1, Line 90: return override_bootblock_gpio_table; please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)