Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42401 )
Change subject: mb/asrock/b85m_pro4: Add missing HWM IRQ on devicetree ......................................................................
mb/asrock/b85m_pro4: Add missing HWM IRQ on devicetree
Otherwise, there are complaints about it from the allocator.
Change-Id: Ibf6124c3720959154d0b9649871f9bf68a912f14 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/asrock/b85m_pro4/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/42401/1
diff --git a/src/mainboard/asrock/b85m_pro4/devicetree.cb b/src/mainboard/asrock/b85m_pro4/devicetree.cb index 54234e0..cb7df0a 100644 --- a/src/mainboard/asrock/b85m_pro4/devicetree.cb +++ b/src/mainboard/asrock/b85m_pro4/devicetree.cb @@ -103,6 +103,7 @@ device pnp 2e.b on # HWM, LED irq 0x30 = 0xe1 # + Fan RPM sense pins io 0x60 = 0x0290 # + HWM base address + irq 0x70 = 0 end device pnp 2e.d off end # VID device pnp 2e.e off end # CIR wake-up
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42401 )
Change subject: mb/asrock/b85m_pro4: Add missing HWM IRQ on devicetree ......................................................................
Patch Set 10: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42401 )
Change subject: mb/asrock/b85m_pro4: Add missing HWM IRQ on devicetree ......................................................................
mb/asrock/b85m_pro4: Add missing HWM IRQ on devicetree
Otherwise, there are complaints about it from the allocator.
Change-Id: Ibf6124c3720959154d0b9649871f9bf68a912f14 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42401 Reviewed-by: Felix Held felix-coreboot@felixheld.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/asrock/b85m_pro4/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/src/mainboard/asrock/b85m_pro4/devicetree.cb b/src/mainboard/asrock/b85m_pro4/devicetree.cb index 54234e0..cb7df0a 100644 --- a/src/mainboard/asrock/b85m_pro4/devicetree.cb +++ b/src/mainboard/asrock/b85m_pro4/devicetree.cb @@ -103,6 +103,7 @@ device pnp 2e.b on # HWM, LED irq 0x30 = 0xe1 # + Fan RPM sense pins io 0x60 = 0x0290 # + HWM base address + irq 0x70 = 0 end device pnp 2e.d off end # VID device pnp 2e.e off end # CIR wake-up
-
Angel Pons (Code Review) -
Felix Held (Code Review)