Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Zheng Bao, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56773 )
Change subject: [WIP]amdfwtool: add support for A/B recovery ......................................................................
Patch Set 1:
(4 comments)
File util/amdfwtool/amdfwtool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125599): https://review.coreboot.org/c/coreboot/+/56773/comment/22396f7c_f3c72bbf PS1, Line 650: ish->checksum = fletcher32(&ish->boot_priority, sizeof(ish_directory_table) - sizeof(uint32_t)); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125599): https://review.coreboot.org/c/coreboot/+/56773/comment/6937f98b_d236acfd PS1, Line 662: count ++; space prohibited before that '++' (ctx:WxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125599): https://review.coreboot.org/c/coreboot/+/56773/comment/78b36a9c_c2164f98 PS1, Line 663: pspdir->header.num_entries ++; space prohibited before that '++' (ctx:WxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125599): https://review.coreboot.org/c/coreboot/+/56773/comment/dd182679_bf62ec37 PS1, Line 808: count ++; space prohibited before that '++' (ctx:WxO)