Change in ...coreboot[master]: mb/google/hatch: Do not pull down GPP_F2 internally
Philip Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33583 Change subject: mb/google/hatch: Do not pull down GPP_F2 internally ...................................................................... mb/google/hatch: Do not pull down GPP_F2 internally There is already an external pull-up/down resistor tied to this pin to identify if the board is single-channel or dual-channel memory SKU. BUG=b:135496271 BRANCH=none TEST=build Signed-off-by: Philip Chen <philipchen@google.com> Change-Id: Ie218657fd9dde113ab26cf5551d1dff1b6e392b6 --- M src/mainboard/google/hatch/variants/baseboard/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/33583/1 diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c index 0b66075..c135d70 100644 --- a/src/mainboard/google/hatch/variants/baseboard/gpio.c +++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c @@ -284,7 +284,7 @@ /* F1 : WWAN_RESET_1V8_ODL */ PAD_CFG_GPO(GPP_F1, 1, DEEP), /* F2 : MEM_CH_SEL */ - PAD_CFG_GPI(GPP_F2, DN_20K, PLTRST), + PAD_CFG_GPI(GPP_F2, NONE, PLTRST), /* F3 : GPP_F3 ==> NC */ PAD_NC(GPP_F3, NONE), /* F4 : CNV_BRI_DT */ -- To view, visit https://review.coreboot.org/c/coreboot/+/33583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie218657fd9dde113ab26cf5551d1dff1b6e392b6 Gerrit-Change-Number: 33583 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Chen <philipchen@google.com> Gerrit-MessageType: newchange
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33583 ) Change subject: mb/google/hatch: Do not pull down GPP_F2 internally ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/33583/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/33583/1//COMMIT_MSG@9 PS1, Line 9: There is already an external pull-up/down resistor Is this true for all variants? -- To view, visit https://review.coreboot.org/c/coreboot/+/33583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie218657fd9dde113ab26cf5551d1dff1b6e392b6 Gerrit-Change-Number: 33583 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Chen <philipchen@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Furquan Shaikh <furquan@google.com> Gerrit-Comment-Date: Tue, 18 Jun 2019 20:41:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33583 ) Change subject: mb/google/hatch: Do not pull down GPP_F2 internally ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/33583/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/33583/1//COMMIT_MSG@9 PS1, Line 9: There is already an external pull-up/down resistor
Is this true for all variants? I checked Hatch, Helios, Kohaku, and Kindred. All of them have external resistors on GPP_F2.
-- To view, visit https://review.coreboot.org/c/coreboot/+/33583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie218657fd9dde113ab26cf5551d1dff1b6e392b6 Gerrit-Change-Number: 33583 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Chen <philipchen@google.com> Gerrit-Reviewer: Philip Chen <philipchen@google.com> Gerrit-Reviewer: Shelley Chen <shchen@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Furquan Shaikh <furquan@google.com> Gerrit-Comment-Date: Tue, 18 Jun 2019 21:04:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan@google.com> Gerrit-MessageType: comment
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33583 ) Change subject: mb/google/hatch: Do not pull down GPP_F2 internally ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://review.coreboot.org/#/c/33583/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/33583/1//COMMIT_MSG@15 PS1, Line 15: build Can you also please boot test this? -- To view, visit https://review.coreboot.org/c/coreboot/+/33583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie218657fd9dde113ab26cf5551d1dff1b6e392b6 Gerrit-Change-Number: 33583 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Chen <philipchen@google.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Philip Chen <philipchen@google.com> Gerrit-Reviewer: Shelley Chen <shchen@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Tue, 18 Jun 2019 21:13:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/33583 to look at the new patch set (#2). Change subject: mb/google/hatch: Do not pull down GPP_F2 internally ...................................................................... mb/google/hatch: Do not pull down GPP_F2 internally There is already an external pull-up/down resistor tied to this pin to identify if the board is single-channel or dual-channel memory SKU. BUG=b:135496271 BRANCH=none TEST=boot hatch Signed-off-by: Philip Chen <philipchen@google.com> Change-Id: Ie218657fd9dde113ab26cf5551d1dff1b6e392b6 --- M src/mainboard/google/hatch/variants/baseboard/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/33583/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/33583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie218657fd9dde113ab26cf5551d1dff1b6e392b6 Gerrit-Change-Number: 33583 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Chen <philipchen@google.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Philip Chen <philipchen@google.com> Gerrit-Reviewer: Shelley Chen <shchen@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33583 ) Change subject: mb/google/hatch: Do not pull down GPP_F2 internally ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/33583/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/33583/1//COMMIT_MSG@15 PS1, Line 15: build
Can you also please boot test this? Sure, my hatch boots fine.
-- To view, visit https://review.coreboot.org/c/coreboot/+/33583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie218657fd9dde113ab26cf5551d1dff1b6e392b6 Gerrit-Change-Number: 33583 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Chen <philipchen@google.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Philip Chen <philipchen@google.com> Gerrit-Reviewer: Shelley Chen <shchen@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Tue, 18 Jun 2019 21:27:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan@google.com> Gerrit-MessageType: comment
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33583 ) Change subject: mb/google/hatch: Do not pull down GPP_F2 internally ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/33583/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/33583/1//COMMIT_MSG@15 PS1, Line 15: build
Sure, my hatch boots fine. Thanks Philip!
-- To view, visit https://review.coreboot.org/c/coreboot/+/33583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie218657fd9dde113ab26cf5551d1dff1b6e392b6 Gerrit-Change-Number: 33583 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Chen <philipchen@google.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Philip Chen <philipchen@google.com> Gerrit-Reviewer: Shelley Chen <shchen@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Tue, 18 Jun 2019 23:11:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Philip Chen <philipchen@google.com> Comment-In-Reply-To: Furquan Shaikh <furquan@google.com> Gerrit-MessageType: comment
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33583 ) Change subject: mb/google/hatch: Do not pull down GPP_F2 internally ...................................................................... Patch Set 2: Code-Review-1 (1 comment) https://review.coreboot.org/#/c/33583/2/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c: https://review.coreboot.org/#/c/33583/2/src/mainboard/google/hatch/variants/... PS2, Line 463: DN_20K Please help set NONE as well. Thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/33583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie218657fd9dde113ab26cf5551d1dff1b6e392b6 Gerrit-Change-Number: 33583 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Chen <philipchen@google.com> Gerrit-Reviewer: David Wu <david_wu@quanta.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Philip Chen <philipchen@google.com> Gerrit-Reviewer: Shelley Chen <shchen@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Wed, 19 Jun 2019 03:07:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33583 ) Change subject: mb/google/hatch: Do not pull down GPP_F2 internally ...................................................................... Patch Set 2: -Code-Review (1 comment) https://review.coreboot.org/#/c/33583/2/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c: https://review.coreboot.org/#/c/33583/2/src/mainboard/google/hatch/variants/... PS2, Line 463: DN_20K
Please help set NONE as well. Thanks. Good catch.
-- To view, visit https://review.coreboot.org/c/coreboot/+/33583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie218657fd9dde113ab26cf5551d1dff1b6e392b6 Gerrit-Change-Number: 33583 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Chen <philipchen@google.com> Gerrit-Reviewer: David Wu <david_wu@quanta.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Philip Chen <philipchen@google.com> Gerrit-Reviewer: Shelley Chen <shchen@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Wed, 19 Jun 2019 03:13:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: David Wu <david_wu@quanta.corp-partner.google.com> Gerrit-MessageType: comment
Hello Shelley Chen, build bot (Jenkins), David Wu, Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/33583 to look at the new patch set (#3). Change subject: mb/google/hatch: Do not pull down GPP_F2 internally ...................................................................... mb/google/hatch: Do not pull down GPP_F2 internally There is already an external pull-up/down resistor tied to this pin to identify if the board is single-channel or dual-channel memory SKU. BUG=b:135496271 BRANCH=none TEST=build Signed-off-by: Philip Chen <philipchen@google.com> Change-Id: Ie218657fd9dde113ab26cf5551d1dff1b6e392b6 --- M src/mainboard/google/hatch/variants/baseboard/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/33583/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/33583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie218657fd9dde113ab26cf5551d1dff1b6e392b6 Gerrit-Change-Number: 33583 Gerrit-PatchSet: 3 Gerrit-Owner: Philip Chen <philipchen@google.com> Gerrit-Reviewer: David Wu <david_wu@quanta.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Philip Chen <philipchen@google.com> Gerrit-Reviewer: Shelley Chen <shchen@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33583 ) Change subject: mb/google/hatch: Do not pull down GPP_F2 internally ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/33583/2/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c: https://review.coreboot.org/#/c/33583/2/src/mainboard/google/hatch/variants/... PS2, Line 463: DN_20K
Good catch. Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/33583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie218657fd9dde113ab26cf5551d1dff1b6e392b6 Gerrit-Change-Number: 33583 Gerrit-PatchSet: 3 Gerrit-Owner: Philip Chen <philipchen@google.com> Gerrit-Reviewer: David Wu <david_wu@quanta.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Philip Chen <philipchen@google.com> Gerrit-Reviewer: Shelley Chen <shchen@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Wed, 19 Jun 2019 03:57:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: David Wu <david_wu@quanta.corp-partner.google.com> Comment-In-Reply-To: Furquan Shaikh <furquan@google.com> Gerrit-MessageType: comment
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33583 ) Change subject: mb/google/hatch: Do not pull down GPP_F2 internally ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/33583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie218657fd9dde113ab26cf5551d1dff1b6e392b6 Gerrit-Change-Number: 33583 Gerrit-PatchSet: 3 Gerrit-Owner: Philip Chen <philipchen@google.com> Gerrit-Reviewer: David Wu <david_wu@quanta.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Philip Chen <philipchen@google.com> Gerrit-Reviewer: Shelley Chen <shchen@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Wed, 19 Jun 2019 05:40:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33583 ) Change subject: mb/google/hatch: Do not pull down GPP_F2 internally ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/33583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie218657fd9dde113ab26cf5551d1dff1b6e392b6 Gerrit-Change-Number: 33583 Gerrit-PatchSet: 3 Gerrit-Owner: Philip Chen <philipchen@google.com> Gerrit-Reviewer: David Wu <david_wu@quanta.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Philip Chen <philipchen@google.com> Gerrit-Reviewer: Shelley Chen <shchen@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Wed, 19 Jun 2019 05:41:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33583 ) Change subject: mb/google/hatch: Do not pull down GPP_F2 internally ...................................................................... mb/google/hatch: Do not pull down GPP_F2 internally There is already an external pull-up/down resistor tied to this pin to identify if the board is single-channel or dual-channel memory SKU. BUG=b:135496271 BRANCH=none TEST=build Signed-off-by: Philip Chen <philipchen@google.com> Change-Id: Ie218657fd9dde113ab26cf5551d1dff1b6e392b6 Reviewed-on: https://review.coreboot.org/c/coreboot/+/33583 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: David Wu <david_wu@quanta.corp-partner.google.com> Reviewed-by: Furquan Shaikh <furquan@google.com> --- M src/mainboard/google/hatch/variants/baseboard/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved David Wu: Looks good to me, but someone else must approve diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c index 0b66075..e309175 100644 --- a/src/mainboard/google/hatch/variants/baseboard/gpio.c +++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c @@ -284,7 +284,7 @@ /* F1 : WWAN_RESET_1V8_ODL */ PAD_CFG_GPO(GPP_F1, 1, DEEP), /* F2 : MEM_CH_SEL */ - PAD_CFG_GPI(GPP_F2, DN_20K, PLTRST), + PAD_CFG_GPI(GPP_F2, NONE, PLTRST), /* F3 : GPP_F3 ==> NC */ PAD_NC(GPP_F3, NONE), /* F4 : CNV_BRI_DT */ @@ -460,7 +460,7 @@ /* C23 : WLAN_PE_RST# */ PAD_CFG_GPO(GPP_C23, 1, DEEP), /* F2 : MEM_CH_SEL */ - PAD_CFG_GPI(GPP_F2, DN_20K, PLTRST), + PAD_CFG_GPI(GPP_F2, NONE, PLTRST), /* F11 : PCH_MEM_STRAP2 */ PAD_CFG_GPI(GPP_F11, NONE, PLTRST), /* F20 : PCH_MEM_STRAP0 */ -- To view, visit https://review.coreboot.org/c/coreboot/+/33583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie218657fd9dde113ab26cf5551d1dff1b6e392b6 Gerrit-Change-Number: 33583 Gerrit-PatchSet: 4 Gerrit-Owner: Philip Chen <philipchen@google.com> Gerrit-Reviewer: David Wu <david_wu@quanta.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Philip Chen <philipchen@google.com> Gerrit-Reviewer: Shelley Chen <shchen@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: merged
participants (4)
-
David Wu (Code Review) -
Furquan Shaikh (Code Review)
-
Patrick Georgi (Code Review)
-
Philip Chen (Code Review)