[S] Change in coreboot[main]: cpu/x86/topology: Fix FSP-S crash caused by shared core ID

[Patrick Rudolph (Code Review)]

Attention is currently required from: Cliff Huang, Jamie Ryu, Jérémy Compostella, Sean Rhodes, Zhixing Ma.

Patrick Rudolph has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/86004?usp=email )

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

Change subject: cpu/x86/topology: Fix FSP-S crash caused by shared core ID
......................................................................

Patch Set 2:

(3 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/86004/comment/da56e70e_1129cd0a?usp... :
PS2, Line 18: GetProcessorInfo
name the coreboot function: `
mp_get_processor_info`

https://review.coreboot.org/c/coreboot/+/86004/comment/e0b89284_bc624f46?usp... :
PS2, Line 21: complete path
what is a complete path?
It sounds like you are combining the following IDs to form the 3 lvl [THREAD/CORE/PACKAGE] as used in EFI_CPU_PHYSICAL_LOCATION "Core" ID:

LEVEL_TYPE_CORE,
LEVEL_TYPE_MODULE,
LEVEL_TYPE_TILE,
LEVEL_TYPE_DIE
LEVEL_TYPE_DIEGRP,

File src/cpu/x86/topology.c:

https://review.coreboot.org/c/coreboot/+/86004/comment/db537ece_3ea4a81b?usp... :
PS2, Line 156: EFI_CPU_PHYSICAL_LOCATION
FSP quirks should be handled in FSP wrapper code, for example in `
mp_get_processor_info`