Attention is currently required from: Martin L Roth, Jason Nien, Martin Roth.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70900 )
Change subject: mb/google/skyrim: Add support for and select USE_SELECTIVE_GOP_INIT
......................................................................
Patch Set 10:
(1 comment)
File src/mainboard/google/skyrim/Kconfig:
https://review.coreboot.org/c/coreboot/+/70900/comment/43a05613_9280162b
PS8, Line 108: VBIOS_CACHE_IN_FMAP
Is there any reason we shouldn't just select this, since the cache region actually *is* in the FMAP […]
I've split this into two Kconfigs, support for the VBIOS cache, and actually using the selective GOP driver init
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70900
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5857fa4a15250bf6478bffa96b16200e318492b1
Gerrit-Change-Number: 70900
Gerrit-PatchSet: 10
Gerrit-Owner: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Tue, 07 Feb 2023 17:17:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Gerrit-MessageType: comment