Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76833?usp=email )
Change subject: soc/intel/common: Add metadata tag definition for crashlog ......................................................................
soc/intel/common: Add metadata tag definition for crashlog
When parsing descriptor table the record can have tag type = 7. This tag contains metadata depending on SOC. The platform may choose to parse it based on implementation of crashlog.
BUG=b:262501347 TEST=Able to build google/rex.
Change-Id: I60dda06950974f7949fa5635141e4b7798c4d1f2 Signed-off-by: Pratikkumar Prajapati pratikkumar.v.prajapati@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/76833 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Subrata Banik subratabanik@google.com --- M src/soc/intel/common/block/include/intelblocks/crashlog.h 1 file changed, 10 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved
diff --git a/src/soc/intel/common/block/include/intelblocks/crashlog.h b/src/soc/intel/common/block/include/intelblocks/crashlog.h index 91e8edd..ceaa9f1 100644 --- a/src/soc/intel/common/block/include/intelblocks/crashlog.h +++ b/src/soc/intel/common/block/include/intelblocks/crashlog.h @@ -25,9 +25,18 @@
#define INVALID_CRASHLOG_RECORD 0xdeadbeef
-/* Tag field definitions */ +/* + * Tag field definitions. + * Each region pointed by the descriptor table contains TAG information. This TAG information + * is used to identify the type of SRAM the region belongs to, for example: + * - TAG 0 represents the SoC PMC region + * - TAG 1 represents the IOE PMC region + * - TAG 7 represents a special case aka metadata information. This metadata information can be + * SoC specific too. + */ #define CRASHLOG_DESCRIPTOR_TABLE_TAG_SOC 0x0 #define CRASHLOG_DESCRIPTOR_TABLE_TAG_IOE 0x1 +#define CRASHLOG_DESCRIPTOR_TABLE_TAG_META 0x7
/* PMC crashlog discovery structs */ typedef union {