Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Roger Wang has posted comments on this change by Roger Wang. ( https://review.coreboot.org/c/coreboot/+/84573?usp=email )
Change subject: mb/google/nissa/var/pujjoga: Change configure_ext_fivr value
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
isn't there a power impact w/ this suggested change ?
From Intel suggestion :
VNNbypass for Pujjoga is FIVR, as current setting is FIVR, should change the setting to "0"
config->ext_fivr_settings.configure_ext_fivr (1 means MBVR, 0 means FIVR)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84573?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idb51a431ba6c6089d5c9d29adad9ab2a67979447
Gerrit-Change-Number: 84573
Gerrit-PatchSet: 1
Gerrit-Owner: Roger Wang
roger2.wang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Nikki Huang
nikki.huang@lcfc.corp-partner.google.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Sat, 28 Sep 2024 07:42:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com