[XS] Change in coreboot[main]: spdtool: ignore utf-8 errors when decoding manufactorer - coreboot-gerrit

1 Oct 2024


      Attention is currently required from: Alexander Couzens, Reka Norman.
Maximilian Brune has posted comments on this change by Alexander Couzens. ( https://review.coreboot.org/c/coreboot/+/84188?usp=email )
Change subject: spdtool: ignore utf-8 errors when decoding manufactorer
......................................................................
Patch Set 1:
(1 comment)
File util/spdtool/spdtool.py:
https://review.coreboot.org/c/coreboot/+/84188/comment/d4b28649_4249c918?usp... :
PS1, Line 151:         return tmp.decode('utf-8', 'ignore').rstrip()
shouldn't the part number be ASCII in the first place?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/84188?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7dfec2a67d7c46459fb96c752f2eb8caafb68fa2
Gerrit-Change-Number: 84188
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Reka Norman rekanorman@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: coreboot org coreboot.org@gmail.com
Gerrit-CC: Jon Murphy jpmurphy@google.com
Gerrit-CC: Karthik Ramasubramanian kramasub@google.com
Gerrit-CC: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Attention: Reka Norman rekanorman@chromium.org
Gerrit-Attention: Alexander Couzens lynxis@fe80.eu
Gerrit-Comment-Date: Tue, 01 Oct 2024 13:36:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No