Change in ...coreboot[master]: qclib: Differentiate between ES_1.0 and ES1.1 silicon

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in coreboot[master]: TEMP:...

Name of user not set (Code Review)

14 Jan 2019 14 Jan '19

11:19 a.m.

nsekar@codeaurora.org has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30903

Change subject: qclib: Differentiate between ES_1.0 and ES1.1 silicon ......................................................................

qclib: Differentiate between ES_1.0 and ES1.1 silicon

The PBL data ptr gets passed at a different location for 1.0 vs 1.1. So let us read the revision from TCSR and pass the right value.

Change-Id: Id23493c8cfc64f62964a453cd32a0ddc4bff9e84 Signed-off-by: Sricharan R sricharan@codeaurora.org Signed-off-by: Nitheesh Sekar nsekar@codeaurora.org --- M src/soc/qualcomm/qcs405/qclib_execute.c 1 file changed, 14 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/30903/1

diff --git a/src/soc/qualcomm/qcs405/qclib_execute.c b/src/soc/qualcomm/qcs405/qclib_execute.c index 917a04c..214128f 100644 --- a/src/soc/qualcomm/qcs405/qclib_execute.c +++ b/src/soc/qualcomm/qcs405/qclib_execute.c @@ -14,6 +14,7 @@ */

#include <string.h> +#include <arch/io.h> #include <arch/cache.h> #include <arch/mmu.h> #include <cbfs.h> @@ -28,7 +29,12 @@ #define DCB_NAME "/dcb" #define QCLIB_NAME "/qclib"

-#define PBL_DATA_PTR 0x8c101a0 //0x14810188 +#define TCSR_SOC_HW_VERSION 0x0194D000 +#define ES_1_0 0x20140100 +#define ES_1_1 0x20140101 + +#define PBL_DATA_PTR_ES_1_0 0x8c101a0 +#define PBL_DATA_PTR_ES_1_1 0x8c111a0

void qclib_load_and_run(void) { @@ -36,6 +42,7 @@ void *arg; int ret_code; struct mmu_context pre_qclib_mmu_context; + void *pbl_data_ptr;

struct prog qclib = PROG_INIT(PROG_REFCODE, CONFIG_CBFS_PREFIX QCLIB_NAME); @@ -67,7 +74,12 @@ if (cbfs_prog_stage_load(&qclib)) goto fail;

- prog_set_entry(&qclib, qclib.entry, (void *)PBL_DATA_PTR); + if (read32((void *) TCSR_SOC_HW_VERSION) == ES_1_1) + pbl_data_ptr = (void *) 0x8c111a0; + else + pbl_data_ptr = (void *) 0x8c101a0; + + prog_set_entry(&qclib, qclib.entry, (void *)pbl_data_ptr);

printk(BIOS_DEBUG, "\n\n\nQCLib is about to Initialize PMIC and DDR\n"); printk(BIOS_DEBUG, "Jumping to QCLib code at %p(%p)\n",

Attachments:

attachment.htm (text/html — 4.6 KB)

Show replies by date

Patrick Georgi (Code Review)

14 Jan 14 Jan

4:25 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30903 )

Change subject: qclib: Differentiate between ES_1.0 and ES1.1 silicon ......................................................................

Patch Set 1:

I updated this patch train to apply on top of current master. there was only a minor change (in libpayload's Makefile.inc/Kconfig for the serial driver), but eventually that rebase would have been required in any case.

-- To view, visit https://review.coreboot.org/c/coreboot/+/30903 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id23493c8cfc64f62964a453cd32a0ddc4bff9e84 Gerrit-Change-Number: 30903 Gerrit-PatchSet: 1 Gerrit-Owner: nsekar@codeaurora.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 14 Jan 2019 15:25:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

6:38 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30903 )

Change subject: qclib: Differentiate between ES_1.0 and ES1.1 silicon ......................................................................

Patch Set 5: Code-Review+1

(2 comments)

https://review.coreboot.org/#/c/30903/4/src/soc/qualcomm/qcs405/qclib_execut... File src/soc/qualcomm/qcs405/qclib_execute.c:

https://review.coreboot.org/#/c/30903/4/src/soc/qualcomm/qcs405/qclib_execut... PS4, Line 78: 0x8c111a0 PBL_DATA_PTR_ES_1_1

https://review.coreboot.org/#/c/30903/4/src/soc/qualcomm/qcs405/qclib_execut... PS4, Line 80: 0x8c101a0 PBL_DATA_PTR_ES_1_0

-- To view, visit https://review.coreboot.org/c/coreboot/+/30903 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id23493c8cfc64f62964a453cd32a0ddc4bff9e84 Gerrit-Change-Number: 30903 Gerrit-PatchSet: 5 Gerrit-Owner: nsekar@codeaurora.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 14 Jan 2019 17:38:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Yuji Sasaki (Code Review)

15 Jan 15 Jan

2:02 a.m.

Yuji Sasaki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30903 )

Change subject: qclib: Differentiate between ES_1.0 and ES1.1 silicon ......................................................................

Patch Set 5: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/30903 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id23493c8cfc64f62964a453cd32a0ddc4bff9e84 Gerrit-Change-Number: 30903 Gerrit-PatchSet: 5 Gerrit-Owner: nsekar@codeaurora.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Yuji Sasaki sasakiy@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 15 Jan 2019 01:02:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Sricharan Ramabadhran (Code Review)

27 Feb 27 Feb

11:54 a.m.

Sricharan Ramabadhran has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30903 )

Change subject: qclib: Differentiate between ES_1.0 and ES1.1 silicon ......................................................................

Patch Set 11:

(1 comment)

...

Patch Set 5: Code-Review+1

(2 comments)

Ok, will use t

https://review.coreboot.org/#/c/30903/4/src/soc/qualcomm/qcs405/qclib_execut... File src/soc/qualcomm/qcs405/qclib_execute.c:

https://review.coreboot.org/#/c/30903/4/src/soc/qualcomm/qcs405/qclib_execut... PS4, Line 78: 0x8c111a0

...

PBL_DATA_PTR_ES_1_1

Ok, will cleanup dead code and also use Macros, for this and other places

-- To view, visit https://review.coreboot.org/c/coreboot/+/30903 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id23493c8cfc64f62964a453cd32a0ddc4bff9e84 Gerrit-Change-Number: 30903 Gerrit-PatchSet: 11 Gerrit-Owner: nsekar@codeaurora.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Yuji Sasaki sasakiy@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Sricharan Ramabadhran srichara@qualcomm.corp-partner.google.com Gerrit-Comment-Date: Wed, 27 Feb 2019 10:54:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: comment

Patrick Georgi (Code Review)

6 Mar 6 Mar

12:28 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30903 )

Change subject: qclib: Differentiate between ES_1.0 and ES1.1 silicon ......................................................................

Patch Set 12: Code-Review+2

(2 comments)

https://review.coreboot.org/#/c/30903/12/src/soc/qualcomm/qcs405/qclib_execu... File src/soc/qualcomm/qcs405/qclib_execute.c:

https://review.coreboot.org/#/c/30903/12/src/soc/qualcomm/qcs405/qclib_execu... PS12, Line 32: 0x0194D000 nit: the rest of the file uses lower cases hex values

https://review.coreboot.org/#/c/30903/12/src/soc/qualcomm/qcs405/qclib_execu... PS12, Line 32: #define TCSR_SOC_HW_VERSION 0x0194D000 : #define ES_1_0 0x20140100 : #define ES_1_1 0x20140101 As long as we really only need them here, it's okay-ish to keep them here, but the SoC revision really has little to do with qclib_execute, does it?

-- To view, visit https://review.coreboot.org/c/coreboot/+/30903 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id23493c8cfc64f62964a453cd32a0ddc4bff9e84 Gerrit-Change-Number: 30903 Gerrit-PatchSet: 12 Gerrit-Owner: nsekar@codeaurora.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Yuji Sasaki sasakiy@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Sricharan Ramabadhran srichara@qualcomm.corp-partner.google.com Gerrit-Comment-Date: Wed, 06 Mar 2019 11:28:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Sricharan Ramabadhran (Code Review)

8 Mar 8 Mar

1:23 p.m.

Sricharan Ramabadhran has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30903 )

Change subject: qclib: Differentiate between ES_1.0 and ES1.1 silicon ......................................................................

Patch Set 12:

(2 comments)

https://review.coreboot.org/#/c/30903/12/src/soc/qualcomm/qcs405/qclib_execu... File src/soc/qualcomm/qcs405/qclib_execute.c:

https://review.coreboot.org/#/c/30903/12/src/soc/qualcomm/qcs405/qclib_execu... PS12, Line 32: 0x0194D000

...

nit: the rest of the file uses lower cases hex values

ok will change to be consistent

https://review.coreboot.org/#/c/30903/12/src/soc/qualcomm/qcs405/qclib_execu... PS12, Line 32: #define TCSR_SOC_HW_VERSION 0x0194D000 : #define ES_1_0 0x20140100 : #define ES_1_1 0x20140101

...

As long as we really only need them here, it's okay-ish to keep them here, but the SoC revision real […]

The only reason as we have done below is to pass the right PBL pointer to qclib

-- To view, visit https://review.coreboot.org/c/coreboot/+/30903 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id23493c8cfc64f62964a453cd32a0ddc4bff9e84 Gerrit-Change-Number: 30903 Gerrit-PatchSet: 12 Gerrit-Owner: nsekar@codeaurora.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Yuji Sasaki sasakiy@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Sricharan Ramabadhran srichara@qualcomm.corp-partner.google.com Gerrit-Comment-Date: Fri, 08 Mar 2019 12:23:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: comment

Name of user not set (Code Review)

14 Mar 14 Mar

4 p.m.

New subject: Change in ...coreboot[master]: TEMP: NOT FOR REVIEW: qclib: Differentiate between ES_1.0 and ES1.1 s...

Hello Yuji Sasaki, build bot (Jenkins), Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/30903

to look at the new patch set (#13).

Change subject: TEMP: NOT FOR REVIEW: qclib: Differentiate between ES_1.0 and ES1.1 silicon ......................................................................

TEMP: NOT FOR REVIEW: qclib: Differentiate between ES_1.0 and ES1.1 silicon

The PBL data ptr gets passed at a different location for 1.0 vs 1.1. So let us read the revision from TCSR and pass the right value.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/30903/13

-- To view, visit https://review.coreboot.org/c/coreboot/+/30903 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id23493c8cfc64f62964a453cd32a0ddc4bff9e84 Gerrit-Change-Number: 30903 Gerrit-PatchSet: 13 Gerrit-Owner: nsekar@codeaurora.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Yuji Sasaki sasakiy@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Sricharan Ramabadhran srichara@qualcomm.corp-partner.google.com Gerrit-MessageType: newpatchset

Patrick Georgi (Code Review)

11 Jul 11 Jul

3:42 p.m.

New subject: Change in coreboot[master]: TEMP: NOT FOR REVIEW: qclib: Differentiate between ES_1.0 and ES1.1 s...

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30903 )

Change subject: TEMP: NOT FOR REVIEW: qclib: Differentiate between ES_1.0 and ES1.1 silicon ......................................................................

Patch Set 22:

we can abandon this, right?

-- To view, visit https://review.coreboot.org/c/coreboot/+/30903 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id23493c8cfc64f62964a453cd32a0ddc4bff9e84 Gerrit-Change-Number: 30903 Gerrit-PatchSet: 22 Gerrit-Owner: Nitheesh Sekar nsekar@codeaurora.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Yuji Sasaki sasakiy@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Sricharan Ramabadhran srichara@qualcomm.corp-partner.google.com Gerrit-Comment-Date: Thu, 11 Jul 2019 13:42:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

11 Mar 11 Mar

4:22 p.m.

New subject: Change in coreboot[master]: TEMP: NOT FOR REVIEW: qclib: Differentiate between ES_1.0 and ES1.1 s...

Patrick Georgi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/30903 )

Change subject: TEMP: NOT FOR REVIEW: qclib: Differentiate between ES_1.0 and ES1.1 silicon ......................................................................

Abandoned

won't be finished here

-- To view, visit https://review.coreboot.org/c/coreboot/+/30903 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id23493c8cfc64f62964a453cd32a0ddc4bff9e84 Gerrit-Change-Number: 30903 Gerrit-PatchSet: 22 Gerrit-Owner: Nitheesh Sekar nsekar@codeaurora.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Yuji Sasaki sasakiy@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Sricharan Ramabadhran srichara@qualcomm.corp-partner.google.com Gerrit-MessageType: abandon

1500

days inactive

1922

days old

coreboot-gerrit@coreboot.org

9 comments

4 participants

tags (0)

participants (4)

Name of user not set (Code Review)
Patrick Georgi (Code Review)
Sricharan Ramabadhran (Code Review)
Yuji Sasaki (Code Review)