Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41984 )
Change subject: Makefile: Drop HAVE_SMI_HANDLER test for smm-class ......................................................................
Makefile: Drop HAVE_SMI_HANDLER test for smm-class
Change-Id: Id0bb5266246dbd959c6497d7c411f908cc49318c Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/google/dedede/Makefile.inc M src/mainboard/intel/jasperlake_rvp/Makefile.inc 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/41984/1
diff --git a/src/mainboard/google/dedede/Makefile.inc b/src/mainboard/google/dedede/Makefile.inc index 9af93dd..76b1af1 100644 --- a/src/mainboard/google/dedede/Makefile.inc +++ b/src/mainboard/google/dedede/Makefile.inc @@ -10,7 +10,7 @@ ramstage-y += ec.c ramstage-y += board_info.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c +smm-y += smihandler.c
subdirs-y += variants/baseboard subdirs-y += spd diff --git a/src/mainboard/intel/jasperlake_rvp/Makefile.inc b/src/mainboard/intel/jasperlake_rvp/Makefile.inc index c1fde49..a1cd12c 100644 --- a/src/mainboard/intel/jasperlake_rvp/Makefile.inc +++ b/src/mainboard/intel/jasperlake_rvp/Makefile.inc @@ -15,7 +15,7 @@ ramstage-y += mainboard.c ramstage-y += board_id.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c +smm-y += smihandler.c
subdirs-y += ../common subdirs-y += variants/baseboard
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41984 )
Change subject: Makefile: Drop HAVE_SMI_HANDLER test for smm-class ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41984 )
Change subject: Makefile: Drop HAVE_SMI_HANDLER test for smm-class ......................................................................
Makefile: Drop HAVE_SMI_HANDLER test for smm-class
Change-Id: Id0bb5266246dbd959c6497d7c411f908cc49318c Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41984 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/mainboard/google/dedede/Makefile.inc M src/mainboard/intel/jasperlake_rvp/Makefile.inc 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/Makefile.inc b/src/mainboard/google/dedede/Makefile.inc index 9af93dd..76b1af1 100644 --- a/src/mainboard/google/dedede/Makefile.inc +++ b/src/mainboard/google/dedede/Makefile.inc @@ -10,7 +10,7 @@ ramstage-y += ec.c ramstage-y += board_info.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c +smm-y += smihandler.c
subdirs-y += variants/baseboard subdirs-y += spd diff --git a/src/mainboard/intel/jasperlake_rvp/Makefile.inc b/src/mainboard/intel/jasperlake_rvp/Makefile.inc index c1fde49..a1cd12c 100644 --- a/src/mainboard/intel/jasperlake_rvp/Makefile.inc +++ b/src/mainboard/intel/jasperlake_rvp/Makefile.inc @@ -15,7 +15,7 @@ ramstage-y += mainboard.c ramstage-y += board_id.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c +smm-y += smihandler.c
subdirs-y += ../common subdirs-y += variants/baseboard
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41984 )
Change subject: Makefile: Drop HAVE_SMI_HANDLER test for smm-class ......................................................................
Patch Set 3:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4783 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4782 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4781 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4780
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Kyösti Mälkki (Code Review)
-
Patrick Georgi (Code Review)