Change in coreboot[master]: soc/intel/common/gpio: Rework PAD config macro to add lock support - coreboot-gerrit

5 Jan 2022


      Attention is currently required from: Subrata Banik, Maulik V Vaghela, Tim Wawrzynczak, Nick Vaccaro, Angel Pons, Meera Ravindranath, Patrick Rudolph.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60774 )
Change subject: soc/intel/common/gpio: Rework PAD config macro to add lock support
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File src/soc/intel/common/block/gpio/gpio.c:
https://review.coreboot.org/c/coreboot/+/60774/comment/0f097954_37dbbe05 
PS3, Line 353: 		gpio_configure_pad(cfg + i);
gpio_lock_pads here?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/60774
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibf8b0a845005ad545266d995449d0aa711f45a61
Gerrit-Change-Number: 60774
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Reviewer: Meera Ravindranath meera.ravindranath@intel.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Meera Ravindranath meera.ravindranath@intel.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Wed, 05 Jan 2022 05:57:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment