[M] Change in coreboot[master]: mb/asrock/b75pro3-m: Add CMOS layout/defaults and vbt.bin
Kevin Keijzer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73451 )
Change subject: mb/asrock/b75pro3-m: Add CMOS layout/defaults and vbt.bin ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/73451/comment/698a385f_5b84719b PS2, Line 9: was lacking
It’d use present tense to describe the current situation: lacks.
Well, it's already merged, right? So if you want me to describe the current situation, I should not make this change then.
https://review.coreboot.org/c/coreboot/+/73451/comment/8979fed9_556e564b PS2, Line 10: could not
Ditto.
Ditto.
https://review.coreboot.org/c/coreboot/+/73451/comment/23480ed0_f317375b PS2, Line 13: I have "borrowed" the files from the similar h77pro4-m port, which : work fine for the b75pro3-m. I can now adjust things like gfx_uma_size : and power_on_after_fail, which are quite useful to be able to modify.
I’d write: Borrow the files from …. Now it’s possible to adjust ….
I can change this, but like I said, it's already merged, so is it still useful to do this? (Feel free to modify the commit message however you want though.)
https://review.coreboot.org/c/coreboot/+/73451/comment/b3381ca1_eecaf366 PS2, Line 18: VGABIOS
Which version.
According to `strings`:
``` Intel(R) Sandybridge/Ivybridge PCI Accelerated SVGA BIOS Build Number: 2137 PC 14.34 03/14/2012 20:08:25 ```
-
Kevin Keijzer (Code Review)