Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27369 )
Change subject: soc/intel/basecode: Add support for updating ucode loaded via FIT
......................................................................
Patch Set 33:
(2 comments)
Patch Set 33:
(1 comment)
The more I'm thinking about this the more I realize that I don't
understand the purpose of this update mechanism.
For being able to perform the update, you already need a RO MCU that
works good enough to get you to ramstage. At this point, you can
already apply additional MCUs from any RW partition. So what kind of
issue would have to be fixed by an update that makes use of this
mechanism?
In other words, what problem can this new update mechanism fix, that
current mechanisms can't? And is it worth the added complexity and
accompanying security degradation (more code is always more error-
prone)?
Microcode patch contains patch for Punit as well, and that has to be applied prior to reset.
Hence the effort to load the updated microcode via FIT.
https://review.coreboot.org/#/c/27369/30//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/27369/30//COMMIT_MSG@10
PS30, Line 10: them
microcode updates.
Done
https://review.coreboot.org/#/c/27369/30//COMMIT_MSG@22
PS30, Line 22: I
Added an option to cbfs tool to do that. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/27369
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab6ba36a2eb587f331fe522c778e2c430c8eb655
Gerrit-Change-Number: 27369
Gerrit-PatchSet: 33
Gerrit-Owner: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: dhaval v sharma
dhaval.v.sharma@intel.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Dhaval Sharma
dhaval.v.sharma@intel.corp-partner.google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Mon, 14 Jan 2019 08:01:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-MessageType: comment