Attention is currently required from: Subrata Banik, Nick Vaccaro, Yu-Ping Wu, Boris Mittelberg.
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73325 )
Change subject: ec/google/chromeec: Use host command API
......................................................................
Patch Set 2:
(1 comment)
File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/73325/comment/81ce6f8f_25471347
PS1, Line 523: struct chromeec_command cmd = {
I see. […]
the variable size param/response cases i'm referring to aren't
implemented in ec_cmd_api.h, so this file isn't in an intermediate
state.
not sure if we can eliminate `struct chromeec_command`.
i think it'll take a fair bit of refactoring of coreboot chromeec support.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73325
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0317405b1ed0c58568078133c17c8cfbc7c21d80
Gerrit-Change-Number: 73325
Gerrit-PatchSet: 2
Gerrit-Owner: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Wed, 03 May 2023 03:04:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment