Change in coreboot[master]: asus/a88xm-e: add the PIRQ routing table
Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48426 ) Change subject: asus/a88xm-e: add the PIRQ routing table ...................................................................... asus/a88xm-e: add the PIRQ routing table Add the PIRQ routing table for this board. Signed-off-by: Mike Banon <mikebdp2@gmail.com> Change-Id: I8fe3fb03ca0e7a2fecb92efeaf621925b198a39f --- M src/mainboard/asus/a88xm-e/Kconfig M src/mainboard/asus/a88xm-e/irq_tables.c 2 files changed, 68 insertions(+), 77 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/48426/1 diff --git a/src/mainboard/asus/a88xm-e/Kconfig b/src/mainboard/asus/a88xm-e/Kconfig index 17fbe28..c889497 100644 --- a/src/mainboard/asus/a88xm-e/Kconfig +++ b/src/mainboard/asus/a88xm-e/Kconfig @@ -42,7 +42,7 @@ config IRQ_SLOT_COUNT int - default 11 + default 21 config VGA_BIOS_ID string diff --git a/src/mainboard/asus/a88xm-e/irq_tables.c b/src/mainboard/asus/a88xm-e/irq_tables.c index 7ca1c4b..47dbb11 100644 --- a/src/mainboard/asus/a88xm-e/irq_tables.c +++ b/src/mainboard/asus/a88xm-e/irq_tables.c @@ -1,84 +1,75 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <arch/pirq_routing.h> -#include <console/console.h> -#include <device/pci_def.h> -#include <string.h> -static void write_pirq_info(struct irq_info *pirq_info, u8 bus, u8 devfn, - u8 link0, u16 bitmap0, u8 link1, u16 bitmap1, - u8 link2, u16 bitmap2, u8 link3, u16 bitmap3, u8 slot, u8 rfu) -{ - pirq_info->bus = bus; - pirq_info->devfn = devfn; - pirq_info->irq[0].link = link0; - pirq_info->irq[0].bitmap = bitmap0; - pirq_info->irq[1].link = link1; - pirq_info->irq[1].bitmap = bitmap1; - pirq_info->irq[2].link = link2; - pirq_info->irq[2].bitmap = bitmap2; - pirq_info->irq[3].link = link3; - pirq_info->irq[3].bitmap = bitmap3; - pirq_info->slot = slot; - pirq_info->rfu = rfu; -} +const struct irq_routing_table intel_irq_routing_table = { + PIRQ_SIGNATURE, /* u32 signature */ + PIRQ_VERSION, /* u16 version */ + 32 + 16 * CONFIG_IRQ_SLOT_COUNT, /* Max. number of devices on the bus */ + 0x00, /* Interrupt router bus */ + (0x14 << 3) | 0x3, /* Interrupt router dev */ + 0, /* IRQs devoted exclusively to PCI usage */ + 0x1022, /* Vendor */ + 0x780e, /* Device */ + 0, /* Miniport */ + { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 }, /* u8 rfu[11] */ + 0x14, /* Checksum (has to be set to some value that + * would give 0 after the sum of all bytes + * for this structure (including checksum). + */ + { + /* bus, dev | fn, {link, bitmap}, {link, bitmap}, {link, bitmap}, {link, bitmap}, slot, rfu */ + /* IOMMU: 0:00.02 - IRQ 3 */ + {0x00, (0x00 << 3) | 0x2, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, + /* APU Integrated Graphics: 0:01.00 - IRQ 3 */ + /* APU HDMI Audio Controller: 0:01.01 - IRQ 4 */ + {0x00, (0x01 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, + /* PCIe GPP to dGPU 1:00.00: 0:02.00 - IRQ 3 */ + {0x00, (0x02 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, + /* PCIe GPP to 2:00.00: 0:04.00 - IRQ 3 */ + {0x00, (0x04 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, + /* PCIe GPP to 3:00.00: 0:05.00 - IRQ 3 */ + {0x00, (0x05 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, + /* PCIe GPP to Eth 4:00.00: 0:06.00 - IRQ 4 */ + {0x00, (0x06 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x0, 0x0}, + /* USB XHCI: 0:10.00 - IRQ 5 */ + {0x00, (0x10 << 3) | 0x0, {{0x03, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, + /* SATA: 0:11.00 - IRQ 7 */ + {0x00, (0x11 << 3) | 0x0, {{0x04, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, + /* USB OHCI1: 0:12.00 - IRQ 5 */ + /* USB EHCI1: 0:12.02 - IRQ 4 */ + {0x00, (0x12 << 3) | 0x0, {{0x03, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, + /* USB OHCI2: 0:13.00 - IRQ 5 */ + /* USB EHCI2: 0:13.02 - IRQ 4 */ + {0x00, (0x16 << 3) | 0x0, {{0x03, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, + /* USB OHCI3: 0:16.00 - IRQ 5 */ + /* USB EHCI3: 0:16.02 - IRQ 4 */ + {0x00, (0x13 << 3) | 0x0, {{0x03, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, + /* Southbridge HD Audio: 0:14.02 - IRQ 3 */ + /* USB OHCI4: 0:14.05 - IRQ 5 */ + {0x00, (0x14 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, + /* Southbridge PCI Port: 0:14.04 - IRQ 11 */ + {0x00, (0x14 << 3) | 0x4, {{0x05, 0xccf0}, {0x06, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, + /* Southbridge PCIe Port 1: 0:15.00 - IRQ 4 */ + {0x00, (0x15 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x0, 0x0}, + /* Southbridge PCIe Port 2: 0:15.01 - IRQ 5 */ + {0x00, (0x15 << 3) | 0x1, {{0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0}, {0x02, 0xccf0} }, 0x0, 0x0}, + /* Southbridge PCIe Port 3: 0:15.02 - IRQ 7 */ + {0x00, (0x15 << 3) | 0x2, {{0x04, 0xccf0}, {0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0} }, 0x0, 0x0}, + /* Southbridge PCIe Port 4: 0:15.03 - IRQ 3 */ + {0x00, (0x15 << 3) | 0x3, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, + /* Discrete Graphics (dGPU) 1:00.00 behind a 0:02.00 PCIe GPP - IRQ 3 */ + {0x01, (0x00 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x1, 0x0}, + /* 2:00.00 behind a 0:04.00 PCIe GPP - IRQ 3 */ + {0x02, (0x00 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x2, 0x0}, + /* 3:00.00 behind a 0:05.00 PCIe GPP - IRQ 4 */ + {0x03, (0x00 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x3, 0x0}, + /* Onboard Ethernet (Eth) 4:00.00 behind a 0:06.00 PCIe GPP - IRQ 4 */ + {0x04, (0x00 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x4, 0x0} + } +}; unsigned long write_pirq_routing_table(unsigned long addr) { - struct irq_routing_table *pirq; - struct irq_info *pirq_info; - u32 slot_num; - - u8 sum = 0; - int i; - - /* Align the table to be 16 byte aligned. */ - addr = ALIGN_UP(addr, 16); - - /* This table must be between 0xf0000 & 0x100000 */ - printk(BIOS_INFO, "Writing IRQ routing tables to 0x%lx...", addr); - - pirq = (void *)(addr); - - pirq->signature = PIRQ_SIGNATURE; - pirq->version = PIRQ_VERSION; - - pirq->rtr_bus = 0; - pirq->rtr_devfn = PCI_DEVFN(0x14, 4); - - pirq->exclusive_irqs = 0; - - pirq->rtr_vendor = 0x1002; - pirq->rtr_device = 0x4384; - - pirq->miniport_data = 0; - - memset(pirq->rfu, 0, sizeof(pirq->rfu)); - - pirq_info = (void *)(&pirq->slots); - slot_num = 0; - - /* pci bridge */ - write_pirq_info(pirq_info, 0, PCI_DEVFN(0x14, 4), - 0x1, 0xdef8, 0x2, 0xdef8, 0x3, 0xdef8, 0x4, 0xdef8, 0, 0); - pirq_info++; - - slot_num++; - - pirq->size = 32 + 16 * slot_num; - - { - const u8 *const v = (u8 *)(pirq); - for (i = 0; i < pirq->size; i++) - sum += v[i]; - } - - sum = pirq->checksum - sum; - - if (sum != pirq->checksum) - pirq->checksum = sum; - - printk(BIOS_INFO, "%s done.\n", __func__); - - return (unsigned long)pirq_info; + return copy_pirq_routing_table(addr, &intel_irq_routing_table); } -- To view, visit https://review.coreboot.org/c/coreboot/+/48426 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8fe3fb03ca0e7a2fecb92efeaf621925b198a39f Gerrit-Change-Number: 48426 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon <mikebdp2@gmail.com> Gerrit-MessageType: newchange
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48426 ) Change subject: asus/a88xm-e: add the PIRQ routing table ...................................................................... Patch Set 1: This is similar to CB:48163 for Lenovo G505S. Yes, imperfect, but still much better than what's in a tree - confirmed by KolibriOS ;-) -- To view, visit https://review.coreboot.org/c/coreboot/+/48426 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8fe3fb03ca0e7a2fecb92efeaf621925b198a39f Gerrit-Change-Number: 48426 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon <mikebdp2@gmail.com> Gerrit-Comment-Date: Mon, 07 Dec 2020 18:50:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48426 ) Change subject: asus/a88xm-e: add the PIRQ routing table ...................................................................... Patch Set 1: (22 comments) https://review.coreboot.org/c/coreboot/+/48426/1/src/mainboard/asus/a88xm-e/... File src/mainboard/asus/a88xm-e/irq_tables.c: https://review.coreboot.org/c/coreboot/+/48426/1/src/mainboard/asus/a88xm-e/... PS1, Line 21: /* bus, dev | fn, {link, bitmap}, {link, bitmap}, {link, bitmap}, {link, bitmap}, slot, rfu */ line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/1/src/mainboard/asus/a88xm-e/... PS1, Line 23: {0x00, (0x00 << 3) | 0x2, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/1/src/mainboard/asus/a88xm-e/... PS1, Line 26: {0x00, (0x01 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/1/src/mainboard/asus/a88xm-e/... PS1, Line 28: {0x00, (0x02 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/1/src/mainboard/asus/a88xm-e/... PS1, Line 30: {0x00, (0x04 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/1/src/mainboard/asus/a88xm-e/... PS1, Line 32: {0x00, (0x05 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/1/src/mainboard/asus/a88xm-e/... PS1, Line 34: {0x00, (0x06 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/1/src/mainboard/asus/a88xm-e/... PS1, Line 36: {0x00, (0x10 << 3) | 0x0, {{0x03, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/1/src/mainboard/asus/a88xm-e/... PS1, Line 38: {0x00, (0x11 << 3) | 0x0, {{0x04, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/1/src/mainboard/asus/a88xm-e/... PS1, Line 41: {0x00, (0x12 << 3) | 0x0, {{0x03, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/1/src/mainboard/asus/a88xm-e/... PS1, Line 44: {0x00, (0x16 << 3) | 0x0, {{0x03, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/1/src/mainboard/asus/a88xm-e/... PS1, Line 47: {0x00, (0x13 << 3) | 0x0, {{0x03, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/1/src/mainboard/asus/a88xm-e/... PS1, Line 50: {0x00, (0x14 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/1/src/mainboard/asus/a88xm-e/... PS1, Line 52: {0x00, (0x14 << 3) | 0x4, {{0x05, 0xccf0}, {0x06, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/1/src/mainboard/asus/a88xm-e/... PS1, Line 54: {0x00, (0x15 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/1/src/mainboard/asus/a88xm-e/... PS1, Line 56: {0x00, (0x15 << 3) | 0x1, {{0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0}, {0x02, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/1/src/mainboard/asus/a88xm-e/... PS1, Line 58: {0x00, (0x15 << 3) | 0x2, {{0x04, 0xccf0}, {0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/1/src/mainboard/asus/a88xm-e/... PS1, Line 60: {0x00, (0x15 << 3) | 0x3, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/1/src/mainboard/asus/a88xm-e/... PS1, Line 62: {0x01, (0x00 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x1, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/1/src/mainboard/asus/a88xm-e/... PS1, Line 64: {0x02, (0x00 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x2, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/1/src/mainboard/asus/a88xm-e/... PS1, Line 66: {0x03, (0x00 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x3, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/1/src/mainboard/asus/a88xm-e/... PS1, Line 68: {0x04, (0x00 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x4, 0x0} line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/48426 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8fe3fb03ca0e7a2fecb92efeaf621925b198a39f Gerrit-Change-Number: 48426 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon <mikebdp2@gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Mon, 07 Dec 2020 18:54:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/48426 to look at the new patch set (#2). Change subject: asus/a88xm-e: add the PIRQ routing table ...................................................................... asus/a88xm-e: add the PIRQ routing table Add the PIRQ routing table for this board. Signed-off-by: Mike Banon <mikebdp2@gmail.com> Change-Id: I8fe3fb03ca0e7a2fecb92efeaf621925b198a39f --- M src/mainboard/asus/a88xm-e/Kconfig M src/mainboard/asus/a88xm-e/irq_tables.c 2 files changed, 68 insertions(+), 77 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/48426/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/48426 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8fe3fb03ca0e7a2fecb92efeaf621925b198a39f Gerrit-Change-Number: 48426 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Banon <mikebdp2@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48426 ) Change subject: asus/a88xm-e: add the PIRQ routing table ...................................................................... Patch Set 2: (22 comments) https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... File src/mainboard/asus/a88xm-e/irq_tables.c: https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 21: /* bus, dev | fn, {{link, bitmap}, {link, bitmap}, {link, bitmap}, {link, bitmap} }, slot, rfu */ line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 23: {0x00, (0x00 << 3) | 0x2, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 26: {0x00, (0x01 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 28: {0x00, (0x02 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 30: {0x00, (0x04 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 32: {0x00, (0x05 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 34: {0x00, (0x06 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 36: {0x00, (0x10 << 3) | 0x0, {{0x03, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 38: {0x00, (0x11 << 3) | 0x0, {{0x04, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 41: {0x00, (0x12 << 3) | 0x0, {{0x03, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 44: {0x00, (0x13 << 3) | 0x0, {{0x03, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 47: {0x00, (0x16 << 3) | 0x0, {{0x03, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 50: {0x00, (0x14 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 52: {0x00, (0x14 << 3) | 0x4, {{0x05, 0xccf0}, {0x06, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 54: {0x00, (0x15 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 56: {0x00, (0x15 << 3) | 0x1, {{0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0}, {0x02, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 58: {0x00, (0x15 << 3) | 0x2, {{0x04, 0xccf0}, {0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 60: {0x00, (0x15 << 3) | 0x3, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 62: {0x01, (0x00 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x1, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 64: {0x02, (0x00 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x2, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 66: {0x03, (0x00 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x3, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/2/src/mainboard/asus/a88xm-e/... PS2, Line 68: {0x04, (0x00 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x4, 0x0} line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/48426 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8fe3fb03ca0e7a2fecb92efeaf621925b198a39f Gerrit-Change-Number: 48426 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Banon <mikebdp2@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Tue, 08 Dec 2020 19:47:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/48426 to look at the new patch set (#3). Change subject: asus/a88xm-e: add the PIRQ routing table ...................................................................... asus/a88xm-e: add the PIRQ routing table Add the PIRQ routing table for this board. Signed-off-by: Mike Banon <mikebdp2@gmail.com> Change-Id: I8fe3fb03ca0e7a2fecb92efeaf621925b198a39f --- M src/mainboard/asus/a88xm-e/Kconfig M src/mainboard/asus/a88xm-e/irq_tables.c 2 files changed, 70 insertions(+), 77 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/48426/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/48426 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8fe3fb03ca0e7a2fecb92efeaf621925b198a39f Gerrit-Change-Number: 48426 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Banon <mikebdp2@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48426 ) Change subject: asus/a88xm-e: add the PIRQ routing table ...................................................................... Patch Set 3: (22 comments) File src/mainboard/asus/a88xm-e/irq_tables.c: https://review.coreboot.org/c/coreboot/+/48426/comment/8d744979_8696a5aa PS3, Line 22: /* bus, dev | fn, {{link, bitmap}, {link, bitmap}, {link, bitmap}, {link, bitmap} }, slot, rfu */ line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/3d366977_8d4d3cae PS3, Line 24: {0x00, (0x00 << 3) | 0x2, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/22f378d9_42969058 PS3, Line 27: {0x00, (0x01 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/4b0c28d0_8a90eca8 PS3, Line 29: {0x00, (0x02 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/910734e3_97d20fd4 PS3, Line 31: {0x00, (0x04 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/2e13d220_f4aa3221 PS3, Line 33: {0x00, (0x05 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/7413967c_6df4547e PS3, Line 35: {0x00, (0x06 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/0c75576b_2ad0dc0f PS3, Line 37: {0x00, (0x10 << 3) | 0x0, {{0x03, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/770852ed_3947b3ec PS3, Line 39: {0x00, (0x11 << 3) | 0x0, {{0x04, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/db2da68d_2c1f34b7 PS3, Line 42: {0x00, (0x12 << 3) | 0x0, {{0x03, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/3c9bcdcf_0b831e83 PS3, Line 45: {0x00, (0x13 << 3) | 0x0, {{0x03, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/515a50ed_307f1c42 PS3, Line 48: {0x00, (0x16 << 3) | 0x0, {{0x03, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/a63cf2fa_677853b0 PS3, Line 51: {0x00, (0x14 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/019e747f_66b05e69 PS3, Line 53: {0x00, (0x14 << 3) | 0x4, {{0x05, 0xccf0}, {0x06, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/117e1d75_d4990b22 PS3, Line 55: {0x00, (0x15 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/4bed4b11_16091c6e PS3, Line 57: {0x00, (0x15 << 3) | 0x1, {{0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0}, {0x02, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/48b43d5a_f2e1da45 PS3, Line 59: {0x00, (0x15 << 3) | 0x2, {{0x04, 0xccf0}, {0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/6bb8603e_7eba3706 PS3, Line 61: {0x00, (0x15 << 3) | 0x3, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/9f2496be_76f091d1 PS3, Line 63: {0x01, (0x00 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x1, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/cd59a711_501edbd0 PS3, Line 65: {0x02, (0x00 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x2, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/dbf91735_cdde9039 PS3, Line 67: {0x03, (0x00 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x3, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/f9fc812d_b7a66578 PS3, Line 69: {0x04, (0x00 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x4, 0x0} line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/48426 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8fe3fb03ca0e7a2fecb92efeaf621925b198a39f Gerrit-Change-Number: 48426 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Banon <mikebdp2@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Tue, 23 Feb 2021 20:12:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48426 ) Change subject: asus/a88xm-e: add the PIRQ routing table ...................................................................... Patch Set 4: (22 comments) File src/mainboard/asus/a88xm-e/irq_tables.c: https://review.coreboot.org/c/coreboot/+/48426/comment/3d106fe6_610084cc PS4, Line 22: /* bus, dev | fn, {{link, bitmap}, {link, bitmap}, {link, bitmap}, {link, bitmap} }, slot, rfu */ line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/1dc5f5f0_7dcab900 PS4, Line 24: {0x00, (0x00 << 3) | 0x2, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/a4fc30f6_643402d1 PS4, Line 27: {0x00, (0x01 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/1a9af58f_a637530a PS4, Line 29: {0x00, (0x02 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/85d1a7b1_78e27393 PS4, Line 31: {0x00, (0x04 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/0c7a8bd7_4696cd8c PS4, Line 33: {0x00, (0x05 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/c369e6a4_cbd2dc31 PS4, Line 35: {0x00, (0x06 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/1d1b55f3_419654f2 PS4, Line 37: {0x00, (0x10 << 3) | 0x0, {{0x03, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/3a11a039_a0dcd8f0 PS4, Line 39: {0x00, (0x11 << 3) | 0x0, {{0x04, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/e3297026_6b20f21d PS4, Line 42: {0x00, (0x12 << 3) | 0x0, {{0x03, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/20a240a1_850d2c09 PS4, Line 45: {0x00, (0x13 << 3) | 0x0, {{0x03, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/34c3533e_9c24a98c PS4, Line 48: {0x00, (0x16 << 3) | 0x0, {{0x03, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/ce4b04cb_a33decf8 PS4, Line 51: {0x00, (0x14 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/5a3f8d7c_a2c982c6 PS4, Line 53: {0x00, (0x14 << 3) | 0x4, {{0x05, 0xccf0}, {0x06, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/21d6fba0_54e81743 PS4, Line 55: {0x00, (0x15 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/f65fa026_307e5bec PS4, Line 57: {0x00, (0x15 << 3) | 0x1, {{0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0}, {0x02, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/236815e0_d5586f41 PS4, Line 59: {0x00, (0x15 << 3) | 0x2, {{0x04, 0xccf0}, {0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/4bdd5371_f35816d1 PS4, Line 61: {0x00, (0x15 << 3) | 0x3, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/56c3a8e4_73bb6588 PS4, Line 63: {0x01, (0x00 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x1, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/ee664ed6_1f71c91c PS4, Line 65: {0x02, (0x00 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x2, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/58eccfde_412de17d PS4, Line 67: {0x03, (0x00 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x3, 0x0}, line over 96 characters https://review.coreboot.org/c/coreboot/+/48426/comment/f650362a_85d68f18 PS4, Line 69: {0x04, (0x00 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x4, 0x0} line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/48426 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8fe3fb03ca0e7a2fecb92efeaf621925b198a39f Gerrit-Change-Number: 48426 Gerrit-PatchSet: 4 Gerrit-Owner: Mike Banon <mikebdp2@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 07 Mar 2021 14:50:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48426 ) Change subject: asus/a88xm-e: add the PIRQ routing table ...................................................................... Patch Set 5: (22 comments) File src/mainboard/asus/a88xm-e/irq_tables.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117712): https://review.coreboot.org/c/coreboot/+/48426/comment/f8e08d53_5c30c242 PS5, Line 22: /* bus, dev | fn, {{link, bitmap}, {link, bitmap}, {link, bitmap}, {link, bitmap} }, slot, rfu */ line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117712): https://review.coreboot.org/c/coreboot/+/48426/comment/eb43e610_960f0ae4 PS5, Line 24: {0x00, (0x00 << 3) | 0x2, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117712): https://review.coreboot.org/c/coreboot/+/48426/comment/e4aeeb72_b0d35758 PS5, Line 27: {0x00, (0x01 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117712): https://review.coreboot.org/c/coreboot/+/48426/comment/c4cc4d03_8b19cb4c PS5, Line 29: {0x00, (0x02 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117712): https://review.coreboot.org/c/coreboot/+/48426/comment/d1ead60d_87c0d170 PS5, Line 31: {0x00, (0x04 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117712): https://review.coreboot.org/c/coreboot/+/48426/comment/678e1214_6d9c26ce PS5, Line 33: {0x00, (0x05 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117712): https://review.coreboot.org/c/coreboot/+/48426/comment/ff8efcd2_ad262d4b PS5, Line 35: {0x00, (0x06 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117712): https://review.coreboot.org/c/coreboot/+/48426/comment/277e468e_c2f2906f PS5, Line 37: {0x00, (0x10 << 3) | 0x0, {{0x03, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117712): https://review.coreboot.org/c/coreboot/+/48426/comment/0570eb60_1d3bdd74 PS5, Line 39: {0x00, (0x11 << 3) | 0x0, {{0x04, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117712): https://review.coreboot.org/c/coreboot/+/48426/comment/e99481d6_ce36d972 PS5, Line 42: {0x00, (0x12 << 3) | 0x0, {{0x03, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117712): https://review.coreboot.org/c/coreboot/+/48426/comment/e1b6f0c3_6468046c PS5, Line 45: {0x00, (0x13 << 3) | 0x0, {{0x03, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117712): https://review.coreboot.org/c/coreboot/+/48426/comment/e84e81ba_dd7d8eab PS5, Line 48: {0x00, (0x16 << 3) | 0x0, {{0x03, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117712): https://review.coreboot.org/c/coreboot/+/48426/comment/780cbf5a_6b4a352e PS5, Line 51: {0x00, (0x14 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117712): https://review.coreboot.org/c/coreboot/+/48426/comment/36b44e37_d415c189 PS5, Line 53: {0x00, (0x14 << 3) | 0x4, {{0x05, 0xccf0}, {0x06, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117712): https://review.coreboot.org/c/coreboot/+/48426/comment/da9b0d30_e8340d02 PS5, Line 55: {0x00, (0x15 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117712): https://review.coreboot.org/c/coreboot/+/48426/comment/6758254b_898f4d2d PS5, Line 57: {0x00, (0x15 << 3) | 0x1, {{0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0}, {0x02, 0xccf0} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117712): https://review.coreboot.org/c/coreboot/+/48426/comment/1706a3c4_86d4a85d PS5, Line 59: {0x00, (0x15 << 3) | 0x2, {{0x04, 0xccf0}, {0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117712): https://review.coreboot.org/c/coreboot/+/48426/comment/759937d0_04ee4715 PS5, Line 61: {0x00, (0x15 << 3) | 0x3, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117712): https://review.coreboot.org/c/coreboot/+/48426/comment/289fa0d3_8ed62e9c PS5, Line 63: {0x01, (0x00 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x1, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117712): https://review.coreboot.org/c/coreboot/+/48426/comment/ca04963c_2552310d PS5, Line 65: {0x02, (0x00 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x2, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117712): https://review.coreboot.org/c/coreboot/+/48426/comment/77d0ab0c_dd67f149 PS5, Line 67: {0x03, (0x00 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x3, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117712): https://review.coreboot.org/c/coreboot/+/48426/comment/a49ddfc1_409633de PS5, Line 69: {0x04, (0x00 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x4, 0x0} line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/48426 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8fe3fb03ca0e7a2fecb92efeaf621925b198a39f Gerrit-Change-Number: 48426 Gerrit-PatchSet: 5 Gerrit-Owner: Mike Banon <mikebdp2@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Comment-Date: Sat, 24 Apr 2021 18:51:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48426 ) Change subject: asus/a88xm-e: add the PIRQ routing table ...................................................................... Patch Set 6: (22 comments) File src/mainboard/asus/a88xm-e/irq_tables.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131801): https://review.coreboot.org/c/coreboot/+/48426/comment/52ad0381_9ca5c47f PS6, Line 22: /* bus, dev | fn, {{link, bitmap}, {link, bitmap}, {link, bitmap}, {link, bitmap} }, slot, rfu */ line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131801): https://review.coreboot.org/c/coreboot/+/48426/comment/361d3ab0_b540fb73 PS6, Line 24: {0x00, (0x00 << 3) | 0x2, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131801): https://review.coreboot.org/c/coreboot/+/48426/comment/41433db3_56e9adb2 PS6, Line 27: {0x00, (0x01 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131801): https://review.coreboot.org/c/coreboot/+/48426/comment/956e5865_7733145d PS6, Line 29: {0x00, (0x02 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131801): https://review.coreboot.org/c/coreboot/+/48426/comment/40c2b5c6_77c90183 PS6, Line 31: {0x00, (0x04 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131801): https://review.coreboot.org/c/coreboot/+/48426/comment/3d6ce1c0_2e7a2bb4 PS6, Line 33: {0x00, (0x05 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131801): https://review.coreboot.org/c/coreboot/+/48426/comment/efaf5899_191fedfb PS6, Line 35: {0x00, (0x06 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131801): https://review.coreboot.org/c/coreboot/+/48426/comment/4ea1a28a_4ae0d33d PS6, Line 37: {0x00, (0x10 << 3) | 0x0, {{0x03, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131801): https://review.coreboot.org/c/coreboot/+/48426/comment/1f783178_f836c4e0 PS6, Line 39: {0x00, (0x11 << 3) | 0x0, {{0x04, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131801): https://review.coreboot.org/c/coreboot/+/48426/comment/ea814ea4_57679277 PS6, Line 42: {0x00, (0x12 << 3) | 0x0, {{0x03, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131801): https://review.coreboot.org/c/coreboot/+/48426/comment/70bf19e6_0dd8d661 PS6, Line 45: {0x00, (0x13 << 3) | 0x0, {{0x03, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131801): https://review.coreboot.org/c/coreboot/+/48426/comment/2adc3a72_a09aae29 PS6, Line 48: {0x00, (0x16 << 3) | 0x0, {{0x03, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131801): https://review.coreboot.org/c/coreboot/+/48426/comment/c7554de6_642ba3e0 PS6, Line 51: {0x00, (0x14 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131801): https://review.coreboot.org/c/coreboot/+/48426/comment/f4df8b37_e5e85d9c PS6, Line 53: {0x00, (0x14 << 3) | 0x4, {{0x05, 0xccf0}, {0x06, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131801): https://review.coreboot.org/c/coreboot/+/48426/comment/78c3ffae_8a6bff4d PS6, Line 55: {0x00, (0x15 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131801): https://review.coreboot.org/c/coreboot/+/48426/comment/9448014a_574a3808 PS6, Line 57: {0x00, (0x15 << 3) | 0x1, {{0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0}, {0x02, 0xccf0} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131801): https://review.coreboot.org/c/coreboot/+/48426/comment/33a9aa4b_0f5b7656 PS6, Line 59: {0x00, (0x15 << 3) | 0x2, {{0x04, 0xccf0}, {0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131801): https://review.coreboot.org/c/coreboot/+/48426/comment/83e34db5_2e97e98d PS6, Line 61: {0x00, (0x15 << 3) | 0x3, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131801): https://review.coreboot.org/c/coreboot/+/48426/comment/e45d689d_d5e14552 PS6, Line 63: {0x01, (0x00 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x1, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131801): https://review.coreboot.org/c/coreboot/+/48426/comment/edff1c1a_41210621 PS6, Line 65: {0x02, (0x00 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x2, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131801): https://review.coreboot.org/c/coreboot/+/48426/comment/bf06c037_7e210d20 PS6, Line 67: {0x03, (0x00 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x3, 0x0}, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131801): https://review.coreboot.org/c/coreboot/+/48426/comment/0b3f8a8b_be6c61ee PS6, Line 69: {0x04, (0x00 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x4, 0x0} line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/48426 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8fe3fb03ca0e7a2fecb92efeaf621925b198a39f Gerrit-Change-Number: 48426 Gerrit-PatchSet: 6 Gerrit-Owner: Mike Banon <mikebdp2@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Comment-Date: Fri, 29 Oct 2021 12:13:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48426 ) Change subject: asus/a88xm-e: add the PIRQ routing table ...................................................................... Patch Set 8: Verified+1 (1 comment) File src/mainboard/asus/a88xm-e/irq_tables.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164827): https://review.coreboot.org/c/coreboot/+/48426/comment/03ed45b2_65a0cb21 PS8, Line 22: /* bus, dev | fn, {{link, bitmap}, {link, bitmap}, {link, bitmap}, {link, bitmap} }, slot, rfu */ line length of 121 exceeds 118 columns -- To view, visit https://review.coreboot.org/c/coreboot/+/48426 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8fe3fb03ca0e7a2fecb92efeaf621925b198a39f Gerrit-Change-Number: 48426 Gerrit-PatchSet: 8 Gerrit-Owner: Mike Banon <mikebdp2@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Comment-Date: Tue, 29 Nov 2022 18:24:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
participants (2)
-
build bot (Jenkins) (Code Review) -
Mike Banon (Code Review)