[S] Change in coreboot[main]: drivers/option: Add CBFS file based option backend - coreboot-gerrit

16 Jan 2025


      Attention is currently required from: Julius Werner, Jérémy Compostella, Nicholas Chin.
Subrata Banik has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/85905?usp=email )
Change subject: drivers/option: Add CBFS file based option backend
......................................................................
Patch Set 12:
(1 comment)
File src/include/option.h:
https://review.coreboot.org/c/coreboot/+/85905/comment/77eed8fb_70a89e76?usp... :
PS9, Line 16: 	return fallback;
...
Shouldn't an error be printed ? A call to get_uint_option() in SMM should be considered an issue as this is not supported.
it was always the case w/ and w/o this CL.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/85905?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifc0439ee42f13f49ae54d4855d1d9333c39b01f5
Gerrit-Change-Number: 85905
Gerrit-PatchSet: 12
Gerrit-Owner: Nicholas Chin nic.c3.14@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-CC: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-CC: Subrata Banik subratabanik@google.com
Gerrit-Attention: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Nicholas Chin nic.c3.14@gmail.com
Gerrit-Comment-Date: Thu, 16 Jan 2025 12:19:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jérémy Compostella jeremy.compostella@intel.com