Attention is currently required from: Felix Held, Paul Menzel, Subrata Banik.
hualin wei has posted comments on this change by hualin wei. ( https://review.coreboot.org/c/coreboot/+/84898?usp=email )
Change subject: mb/google/dedede/var/awasuki: Decrease touchpad I2C freq below 400 kHz
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84898/comment/24c847a9_c16d7b18?usp... :
PS3, Line 7: Adjust touchpad I2C frequency
Maybe: […]
Done
https://review.coreboot.org/c/coreboot/+/84898/comment/d532b036_a3790298?usp... :
PS3, Line 9: Modify the I2C frequency of the touchpad between 380Khz and 400Khz to meet the spec.
Please use 72 characters per line.
Done
https://review.coreboot.org/c/coreboot/+/84898/comment/44b9f721_f12fca25?usp... :
PS3, Line 17: Check wave form and met the spec.
Check that the wave form meets the spec.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84898?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5ccaa3a669e18319311de14833966410c7adf40d
Gerrit-Change-Number: 84898
Gerrit-PatchSet: 4
Gerrit-Owner: hualin wei
weihualin@huaqin.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 29 Oct 2024 08:02:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org