Change in coreboot[master]: soc/intel/alderlake: Check clkreq overlap - coreboot-gerrit

5 Jan 2022


      Attention is currently required from: Subrata Banik, Kane Chen, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60401 )
Change subject: soc/intel/alderlake: Check clkreq overlap
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/60401/comment/47bb3a46_97623101 
PS5, Line 51: static
...
the reason is there are 2 pcie_rp_init call. […]
Oh right the CLKREQ all come from the PCH regardless, so this will warn even if PCH & CPU RPs share a CLKREQ#. Sorry, that makes sense now 😊
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/60401
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2f701a19118f4702c227b17e43b6551591d9b344
Gerrit-Change-Number: 60401
Gerrit-PatchSet: 5
Gerrit-Owner: Kane Chen kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Kane Chen kane.chen@intel.corp-partner.google.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Wed, 05 Jan 2022 02:46:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Subrata Banik subratabanik@google.com
Comment-In-Reply-To: Kane Chen kane.chen@intel.corp-partner.google.com
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-MessageType: comment