Attention is currently required from: Bora Guvendik, Cliff Huang, Kyoung Il Kim.
Jérémy Compostella has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/85196?usp=email )
Change subject: include/device/pci_ids.h: Add DIDs for Touch controller ......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85196/comment/98f27a0c_606dd687?usp... : PS1, Line 7: include/device/pci_ids.h: Add DIDs for Touch controller Looking at git log, `device/pci_ids: ` prefix is enough. Also, what about `device/pci_ids: Add Device IDs for MTL and PTL Touch Controller`
https://review.coreboot.org/c/coreboot/+/85196/comment/9f14cf2a_a93c9c9d?usp... : PS1, Line 13: 0x7ea4 0x7ea4 ? or 0x7e4a ?
https://review.coreboot.org/c/coreboot/+/85196/comment/4338a97c_041b2d73?usp... : PS1, Line 13: 0x7e48 and 0x7ea4 are the DIDs when ThcMode is 0 (default) for THC0 nit: If this is default, shouldn't the name of the constant be suffixed with `_DEFAULT` instead of `_INTEL` ?
https://review.coreboot.org/c/coreboot/+/85196/comment/987fddbc_c0f42baa?usp... : PS1, Line 19: Unnecessary leading space