[S] Change in coreboot[main]: mb/google/guybrush: Set PS2K_IRQ to level/low

Attention is currently required from: Jason Nien, Karthik Ramasubramanian, Martin L Roth, Paul Menzel. Mark Hasemeyer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78137?usp=email ) Change subject: mb/google/guybrush: Set PS2K_IRQ to level/low ...................................................................... Patch Set 4: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/78137/comment/327dfaa9_ae990c85 : PS3, Line 12: From https://review.coreboot.org/c/coreboot/+/54924:
git operates with the hashes (74bce48f1d445053b217913df79a77dfe286e893), so I’d use that. Done
https://review.coreboot.org/c/coreboot/+/78137/comment/90631dcc_bd8cb7f2 : PS3, Line 13: > The default state for the IRQ lines when the eSPI controller comes : > out of reset is high. This is because the IRQ lines are shared with : > the other IRQ sources using AND gates. This means that in order to : > not cause any spurious interrupts or miss any interrupts, the : > IO-APIC must use a low polarity trigger.
Remove the trailing two spaces? Did you mean the leading spaces? I removed them.
-- To view, visit https://review.coreboot.org/c/coreboot/+/78137?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7d093d94a666263684645ef724e945069c68c806 Gerrit-Change-Number: 78137 Gerrit-PatchSet: 4 Gerrit-Owner: Mark Hasemeyer <markhas@google.com> Gerrit-Reviewer: Jason Nien <jason.nien@amd.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth@amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Martin L Roth <gaumless@gmail.com> Gerrit-Attention: Jason Nien <jason.nien@amd.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub@google.com> Gerrit-Comment-Date: Tue, 31 Oct 2023 22:16:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter@mailbox.org> Gerrit-MessageType: comment
participants (1)
-
Mark Hasemeyer (Code Review)