Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34743 )
Change subject: mb/google/hatch/variants/helios: Update DPTF parameters and TDP PL1/PL2
......................................................................
Patch Set 2: Code-Review+2
As per the last reply from Hank Lin, providing my this comment.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34743
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic7a96c33ce710c32b57e2ad8066830ff83398c57
Gerrit-Change-Number: 34743
Gerrit-PatchSet: 2
Gerrit-Owner: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 06 Sep 2019 04:21:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment