Attention is currently required from: Arthur Heymans, Elyes Haouas, Martin L Roth, Sergii Dmytruk.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76787?usp=email )
Change subject: commonlib/bsd/tpm_log_defs.h: Use C99 flexible arrays
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
Patchset:
PS2:
I have nothing against dropping the field and modifying `cbmem` and would prefer this solution over […]
If we want to be ISO 99 compliant we have to remove the event property at the end of the tcpa_log_entry_header struct, since it is included in the tcpa_spec_entry struct. Therefore I would prefer the "ugly" conversion in cbmem (like it is implemented in the latest patchset)
File util/cbmem/cbmem.c:
https://review.coreboot.org/c/coreboot/+/76787/comment/3598eb82_ff4d6ea4 :
PS5, Line 915: uint8_t *ptr = (uint8_t *)log_entry + sizeof(*log_entry);
nit:
maybe use something like "event_ptr" instead of "ptr".
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76787?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5b08b81d5df7a7500faa2c88d04f13dde05b6ea8
Gerrit-Change-Number: 76787
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Fri, 01 Sep 2023 22:05:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr
Gerrit-MessageType: comment