Attention is currently required from: Nick Vaccaro, Robert Chen, Subrata Banik.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79247?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/nissa/var/quandiso: Update P-sensor tuning
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/google/brya/variants/quandiso/gpio.c:
https://review.coreboot.org/c/coreboot/+/79247/comment/4ccc5c5e_7995f11d :
PS7, Line 19: /* B5 : I2C2_SDA ==> I2C_P_SENSOR_SDA */
please also describe the gpio change in comment.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79247?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7c687677a797415d80be4c420484d3346a8455f6
Gerrit-Change-Number: 79247
Gerrit-PatchSet: 7
Gerrit-Owner: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Comment-Date: Tue, 05 Dec 2023 15:09:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment