Attention is currently required from: Paul Menzel, Nick Vaccaro, Scott Chao.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60270 )
Change subject: mb/google/brya/var/gimble: Decrease touchscreen T3 timing to 200ms
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60270/comment/cb6de46d_b1451af0
PS3, Line 9: We set T3 as 300ms to meet Elan's spec, but the resume/suspend times are greater than 500ms, which is the spec for Chromebooks. The actual kernel timing has been measured, and given the ACPI delay after deasserting reset in addition to
: the delay until the kernel driver accesses the device, delaying
: only 200ms in the ACPI method is also sufficient to meet the 300ms
: requirement.
reflow text for 72 characters wide please
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60270
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4bb4eda09686cb59b6e19c741aa2b78d84332d2a
Gerrit-Change-Number: 60270
Gerrit-PatchSet: 3
Gerrit-Owner: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Comment-Date: Wed, 05 Jan 2022 02:44:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment