[XS] Change in coreboot[master]: amdfwtool: Allow bios table source addresses to select base - coreboot-gerrit

3 Jul 2023


      Attention is currently required from: Bao Zheng, Felix Held, Martin L Roth.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76163?usp=email )
Change subject: amdfwtool: Allow bios table source addresses to select base
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
...
shouldn't this be done for all src, dest and size parameters to be consistent?
I'll look into that for another patch series - this was to just get APOB working with as few changes as possible.
With the use of the `get_fmap_vaule` macro, I was able to get `shell printf "%#x"` working inline, so this patch is no longer necessary.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/76163?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45474600048a33ad186ba4d1baed7b5891ffdefe
Gerrit-Change-Number: 76163
Gerrit-PatchSet: 2
Gerrit-Owner: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Bao Zheng fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Bao Zheng fishbaozi@gmail.com
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 03 Jul 2023 14:35:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment