Change in coreboot[master]: soc/amd/picasso: Move IVRS generation code to common - coreboot-gerrit

3 Aug 2021


      Attention is currently required from: Jason Glenesk, Marshall Dawson.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56450 )
Change subject: soc/amd/picasso: Move IVRS generation code to common
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/soc/amd/common/block/include/amdblocks/acpi.h:
https://review.coreboot.org/c/coreboot/+/56450/comment/ac7df229_1d8c05c4 
PS2, Line 62: unsigned long acpi_fill_ivrs(acpi_ivrs_t *ivrs, unsigned long current);
...
this function prototype is already defined in src/include/acpi/acpi. […]
oh, the function prototype i saw in there was for acpi_fill_ivrs_ioapic, so ignore my comment
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/56450
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icd5fec3a9d66e8301e267312020e726d9bc1aa70
Gerrit-Change-Number: 56450
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Glenesk jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt Papageorge matthewpapa07@gmail.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Jason Glenesk jason.glenesk@amd.corp-partner.google.com
Gerrit-Comment-Date: Tue, 03 Aug 2021 15:09:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment