Matt DeVillier (matt.devillier@gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17017
-gerrit
commit 103d6a85f4ef691aa5c94e4004479f944170b622 Author: Prabal Saha coolstarorganization@gmail.com Date: Thu Oct 13 07:52:23 2016 -0700
google/parrot: Fix keyboard interrupts, DSDT
Commit 967cd9a [ChromeOS: fix Kconfig dependencies] broke keyboard interrupts on parrot by making SERIRQ_CONTINUOUS_MODE conditional on CONFIG_CHROMEOS, which it should not be; fix by moving back under main board specific options config.
Additionally, Windows [8/8.1/10] fails to enumerate the keyboard when its ACPI entry is located under the SIO device since it is missing an _HID entry, so add the appropriate value per ACPI spec 5 ch. 9.7
Change-Id: Ia69e9b326001d2026b15b4ec03c94f7d03c8a700 Signed-off-by: Prabal Saha coolstarorganization@gmail.com Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- src/ec/compal/ene932/acpi/superio.asl | 1 + src/mainboard/google/parrot/Kconfig | 5 ++--- 2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/ec/compal/ene932/acpi/superio.asl b/src/ec/compal/ene932/acpi/superio.asl index 8eba623..f152bba 100644 --- a/src/ec/compal/ene932/acpi/superio.asl +++ b/src/ec/compal/ene932/acpi/superio.asl @@ -16,6 +16,7 @@ // Scope is _SB.PCI0.LPCB
Device (SIO) { + Name (_HID, EisaId("PNP0A05")) Name (_UID, 0) Name (_ADR, 0)
diff --git a/src/mainboard/google/parrot/Kconfig b/src/mainboard/google/parrot/Kconfig index 974c58f..7b6b49b 100644 --- a/src/mainboard/google/parrot/Kconfig +++ b/src/mainboard/google/parrot/Kconfig @@ -14,13 +14,12 @@ config BOARD_SPECIFIC_OPTIONS # dummy select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_LPC_TPM select INTEL_INT15 + # Workaround for EC/KBC IRQ1. + select SERIRQ_CONTINUOUS_MODE
config CHROMEOS select VBOOT_VBNV_CMOS
- # Workaround for EC/KBC IRQ1. - select SERIRQ_CONTINUOUS_MODE - config MAINBOARD_DIR string default google/parrot