Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30244 )
Change subject: sb/intel/i82801gx: Autodisable functions based on devicetree
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/#/c/30244/12/src/southbridge/intel/i82801gx/i828...
File src/southbridge/intel/i82801gx/i82801gx.c:
https://review.coreboot.org/#/c/30244/12/src/southbridge/intel/i82801gx/i828...
PS12, Line 25: switch (devfn) {
why is internal lan missing ?
The internal LAN is on the bus behind the PCI bridge afaict from the datasheets. No coreboot device is using it, so it was easier to still disable it in the romstage.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30244
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I83576599538a02d295fe00b35826f98d8c97d1cf
Gerrit-Change-Number: 30244
Gerrit-PatchSet: 12
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
damien@zamaudio.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Comment-Date: Sun, 23 Dec 2018 19:25:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment