Attention is currently required from: Sean Rhodes, Tim Wawrzynczak, Michael Niewöhner.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60545 )
Change subject: soc/intel/tigerlake: Hook up FSP hyper-threading setting to option API
......................................................................
Patch Set 6:
(1 comment)
File src/soc/intel/tigerlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/60545/comment/ae12cba4_41520976
PS6, Line 25: m_cfg->HyperThreading = get_uint_option("hyper_threading", CONFIG(FSP_HYPERTHREADING))
A setting that can be changed isn't obsolete
Not sure what you mean. Of course the setting itself is not obsolete, but with this patch the related code in the mainboard directory is obsolete, because it does the same as in soc/tgl then.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60545
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I49bbd4a776b4e6c55cb373bbf88a3ca076342e3e
Gerrit-Change-Number: 60545
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Sat, 30 Apr 2022 20:24:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes
sean@starlabs.systems
Gerrit-MessageType: comment