Change in coreboot[master]: cpu/x86/{mp_init.c, sipi_vector.S}: Fix SIPI vector cpu_info
Attention is currently required from: Furquan Shaikh, Paul Menzel, Julius Werner, Eric Peers. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57565 )
Change subject: cpu/x86/{mp_init.c, sipi_vector.S}: Fix SIPI vector cpu_info ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57565/comment/1c178971_89e10081 PS2, Line 29:
So is the tag below correct? […]
Maybe? Or maybe the one that added cpu_info. I've submitted so many CLs trying to get coop working, and haven't tagged them: https://review.coreboot.org/q/message:%2522b:179699789%2522
I can tag this one if you want though.
https://review.coreboot.org/c/coreboot/+/57565/comment/6abd917c_83e81810 PS2, Line 32: executing the SIPI vector.
do we also need tests across both intel and amd?
I'm sure it would be reproducable in QEMU. I've never tried running it though.
The change uses plain vanilla x86, so there won't be a difference between Intel or AMD.
-
Raul Rangel (Code Review)