Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36107 )
Change subject: google/auron: hook up libgfxinit ......................................................................
google/auron: hook up libgfxinit
Test: build/boot lulu variant with libgfxinit
Change-Id: I867b2604861ebae02936e7fc0e7230a6adcb2d20 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/auron/Kconfig M src/mainboard/google/auron/Makefile.inc A src/mainboard/google/auron/gma-mainboard.ads 3 files changed, 33 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/36107/1
diff --git a/src/mainboard/google/auron/Kconfig b/src/mainboard/google/auron/Kconfig index 13348a3..b4ef3a8 100644 --- a/src/mainboard/google/auron/Kconfig +++ b/src/mainboard/google/auron/Kconfig @@ -9,6 +9,7 @@ select HAVE_OPTION_TABLE select HAVE_ACPI_RESUME select MAINBOARD_HAS_CHROMEOS + select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_LPC_TPM select MAINBOARD_HAS_TPM1 select INTEL_INT15 diff --git a/src/mainboard/google/auron/Makefile.inc b/src/mainboard/google/auron/Makefile.inc index 6b1de05..ca42470 100644 --- a/src/mainboard/google/auron/Makefile.inc +++ b/src/mainboard/google/auron/Makefile.inc @@ -35,3 +35,5 @@ CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/include
romstage-y += variants/$(VARIANT_DIR)/gpio.c + +ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads diff --git a/src/mainboard/google/auron/gma-mainboard.ads b/src/mainboard/google/auron/gma-mainboard.ads new file mode 100644 index 0000000..d110261 --- /dev/null +++ b/src/mainboard/google/auron/gma-mainboard.ads @@ -0,0 +1,30 @@ +-- +-- This file is part of the coreboot project. +-- +-- This program is free software; you can redistribute it and/or modify +-- it under the terms of the GNU General Public License as published by +-- the Free Software Foundation; either version 2 of the License, or +-- (at your option) any later version. +-- +-- This program is distributed in the hope that it will be useful, +-- but WITHOUT ANY WARRANTY; without even the implied warranty of +-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +-- GNU General Public License for more details. +-- + +with HW.GFX.GMA; +with HW.GFX.GMA.Display_Probing; + +use HW.GFX.GMA; +use HW.GFX.GMA.Display_Probing; + +private package GMA.Mainboard is + + ports : constant Port_List := + (Internal, + HDMI1, + DP1, + DP2, + others => Disabled); + +end GMA.Mainboard;
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36107 )
Change subject: google/auron: hook up libgfxinit ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36107/1/src/mainboard/google/auron/... File src/mainboard/google/auron/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/36107/1/src/mainboard/google/auron/... PS1, Line 25: HDMI1, : DP1, : DP2, Are these tested? It seems odd to have HDMI and USB-C DP-altmode share a connector.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36107 )
Change subject: google/auron: hook up libgfxinit ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36107/1/src/mainboard/google/auron/... File src/mainboard/google/auron/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/36107/1/src/mainboard/google/auron/... PS1, Line 25: HDMI1, : DP1, : DP2,
Are these tested? It seems odd to have HDMI and USB-C DP-altmode share a connector.
I've learned in the meantime that an HDMI alt mode exists as well. Still would like to have it mentioned in the commit message if it was tested.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36107 )
Change subject: google/auron: hook up libgfxinit ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36107/1/src/mainboard/google/auron/... File src/mainboard/google/auron/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/36107/1/src/mainboard/google/auron/... PS1, Line 25: HDMI1, : DP1, : DP2,
I've learned in the meantime that an HDMI alt mode exists as well. Still […]
still working with another dev w/SAMUS to get external outputs (both DP and HDMI via USB-C) tested prior to submission
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36107 )
Change subject: google/auron: hook up libgfxinit ......................................................................
Patch Set 1: Code-Review+2
Please comment which ports were actually tested.
Hello Angel Pons, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36107
to look at the new patch set (#2).
Change subject: google/auron: hook up libgfxinit ......................................................................
google/auron: hook up libgfxinit
Internal/external displays functional on all variants other than Samus. Unable to verify external outputs on Samus (USB-C using DP/HDMI adapter).
Test: build/boot lulu variant with libgfxinit, verify internal/ external displays functional prior to OS display driver loaded. Both linear framebuffer and scaled VGA text modes functional.
Change-Id: I867b2604861ebae02936e7fc0e7230a6adcb2d20 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/auron/Kconfig M src/mainboard/google/auron/Makefile.inc A src/mainboard/google/auron/gma-mainboard.ads 3 files changed, 33 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/36107/2
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36107 )
Change subject: google/auron: hook up libgfxinit ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36107/1/src/mainboard/google/auron/... File src/mainboard/google/auron/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/36107/1/src/mainboard/google/auron/... PS1, Line 25: HDMI1, : DP1, : DP2,
still working with another dev w/SAMUS to get external outputs (both DP and HDMI via USB-C) tested p […]
Done
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36107 )
Change subject: google/auron: hook up libgfxinit ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36107/1/src/mainboard/google/auron/... File src/mainboard/google/auron/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/36107/1/src/mainboard/google/auron/... PS1, Line 25: HDMI1, : DP1, : DP2,
still working with another dev w/SAMUS to get external outputs (both DP and HDMI via USB-C) tested p […]
Done
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36107 )
Change subject: google/auron: hook up libgfxinit ......................................................................
google/auron: hook up libgfxinit
Internal/external displays functional on all variants other than Samus. Unable to verify external outputs on Samus (USB-C using DP/HDMI adapter).
Test: build/boot lulu variant with libgfxinit, verify internal/ external displays functional prior to OS display driver loaded. Both linear framebuffer and scaled VGA text modes functional.
Change-Id: I867b2604861ebae02936e7fc0e7230a6adcb2d20 Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36107 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/mainboard/google/auron/Kconfig M src/mainboard/google/auron/Makefile.inc A src/mainboard/google/auron/gma-mainboard.ads 3 files changed, 33 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/mainboard/google/auron/Kconfig b/src/mainboard/google/auron/Kconfig index 13348a3..b4ef3a8 100644 --- a/src/mainboard/google/auron/Kconfig +++ b/src/mainboard/google/auron/Kconfig @@ -9,6 +9,7 @@ select HAVE_OPTION_TABLE select HAVE_ACPI_RESUME select MAINBOARD_HAS_CHROMEOS + select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_LPC_TPM select MAINBOARD_HAS_TPM1 select INTEL_INT15 diff --git a/src/mainboard/google/auron/Makefile.inc b/src/mainboard/google/auron/Makefile.inc index 6b1de05..ca42470 100644 --- a/src/mainboard/google/auron/Makefile.inc +++ b/src/mainboard/google/auron/Makefile.inc @@ -35,3 +35,5 @@ CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/include
romstage-y += variants/$(VARIANT_DIR)/gpio.c + +ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads diff --git a/src/mainboard/google/auron/gma-mainboard.ads b/src/mainboard/google/auron/gma-mainboard.ads new file mode 100644 index 0000000..d110261 --- /dev/null +++ b/src/mainboard/google/auron/gma-mainboard.ads @@ -0,0 +1,30 @@ +-- +-- This file is part of the coreboot project. +-- +-- This program is free software; you can redistribute it and/or modify +-- it under the terms of the GNU General Public License as published by +-- the Free Software Foundation; either version 2 of the License, or +-- (at your option) any later version. +-- +-- This program is distributed in the hope that it will be useful, +-- but WITHOUT ANY WARRANTY; without even the implied warranty of +-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +-- GNU General Public License for more details. +-- + +with HW.GFX.GMA; +with HW.GFX.GMA.Display_Probing; + +use HW.GFX.GMA; +use HW.GFX.GMA.Display_Probing; + +private package GMA.Mainboard is + + ports : constant Port_List := + (Internal, + HDMI1, + DP1, + DP2, + others => Disabled); + +end GMA.Mainboard;
-
Matt DeVillier (Code Review) -
Nico Huber (Code Review)