Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30963
Change subject: util/autoport: Trim gfx.did to size ......................................................................
util/autoport: Trim gfx.did to size
Since the values are hardcoded, we might as well hardcode values that make sense.
Change-Id: I3ac0e2d74a42c1fe55b1cdc3e2a970ae80cc9f37 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M util/autoport/sandybridge.go 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/30963/1
diff --git a/util/autoport/sandybridge.go b/util/autoport/sandybridge.go index cf2b859..79b0714 100644 --- a/util/autoport/sandybridge.go +++ b/util/autoport/sandybridge.go @@ -53,7 +53,7 @@ "gfx.link_frequency_270_mhz": FormatBool(link_frequency > 200000), /* FIXME:XX hardcoded. */ "gfx.ndid": "3", - "gfx.did": "{ 0x80000100, 0x80000240, 0x80000410, 0x80000410, 0x00000005 }", + "gfx.did": "{ 0x80000100, 0x80000240, 0x80000410 }", }, Children: []DevTreeNode{ {
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30963 )
Change subject: util/autoport: Trim gfx.did to size ......................................................................
Patch Set 1: Code-Review+1
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30963 )
Change subject: util/autoport: Trim gfx.did to size ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30963 )
Change subject: util/autoport: Trim gfx.did to size ......................................................................
util/autoport: Trim gfx.did to size
Since the values are hardcoded, we might as well hardcode values that make sense.
Change-Id: I3ac0e2d74a42c1fe55b1cdc3e2a970ae80cc9f37 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/30963 Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/autoport/sandybridge.go 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/util/autoport/sandybridge.go b/util/autoport/sandybridge.go index 582a856..9972598 100644 --- a/util/autoport/sandybridge.go +++ b/util/autoport/sandybridge.go @@ -55,7 +55,7 @@ "gfx.link_frequency_270_mhz": FormatBool(link_frequency > 200000), /* FIXME:XX hardcoded. */ "gfx.ndid": "3", - "gfx.did": "{ 0x80000100, 0x80000240, 0x80000410, 0x80000410, 0x00000005 }", + "gfx.did": "{ 0x80000100, 0x80000240, 0x80000410 }", }, Children: []DevTreeNode{ {
-
Angel Pons (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)