Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31352 )
Change subject: soc/intel/apl: Implement power-failure-state API ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/31352/8/src/soc/intel/apollolake/pm... File src/soc/intel/apollolake/pmc.c:
https://review.coreboot.org/c/coreboot/+/31352/8/src/soc/intel/apollolake/pm... PS8, Line 110: pmc_set_power_failure_state(PCI_DEV_INVALID); Please add a comment here as to why you're using PCI_DEV_INVALID
https://review.coreboot.org/c/coreboot/+/31352/8/src/soc/intel/apollolake/pm... PS8, Line 130: PCI_DEV_INVALID Please add a comment here as to why you're using PCI_DEV_INVALID
-
Tim Wawrzynczak (Code Review)