Attention is currently required from: Bao Zheng, Jason Glenesk, Raul Rangel, Marshall Dawson, Zheng Bao.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49966 )
Change subject: [WIP]mb/amd/majolica: Add eSPI support
......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/amd/majolica/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/49966/comment/d3ce42a0_88b166fe
PS4, Line 5: .std_io_decode_bitmap = ESPI_DECODE_IO_0X60_0X64_EN,
even though the post code display doesn't work yet, i'd still add the port 80 espi decode here
https://review.coreboot.org/c/coreboot/+/49966/comment/9742fa6e_279d7f88
PS4, Line 6: .generic_io_range[0] = {
: .base = 0x662,
: .size = 8,
: },
is this currently needed? not sure what this is for exactly
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49966
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3e82a51173f561df560c36528a9b7ec26cf489b5
Gerrit-Change-Number: 49966
Gerrit-PatchSet: 4
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Fri, 29 Jan 2021 15:52:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment