Change in coreboot[master]: soc/intel/common: pmclib: make use of the new ETR address API

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36570 )

Change subject: soc/intel/common: pmclib: make use of the new ETR address API
......................................................................


Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36570/4/src/soc/intel/common/block/... 
File src/soc/intel/common/block/pmc/pmclib.c:

https://review.coreboot.org/c/coreboot/+/36570/4/src/soc/intel/common/block/... 
PS4, Line 432: void pmc_global_reset_lock(void)
             : {
             : 	uint32_t *etr = soc_read_pmc_etr_addr();
             : 	uint32_t reg;
             : 
             : 	reg = read32(etr);
             : 	reg = (reg & ~CF9_GLB_RST) | CF9_LOCK;
             : 	write32(etr, reg);
             : }
Is it really worth it to have a function and callback for something that can be written down in 1 or 2 lines of code?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/36570
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I49f59efb4a7c7d3d629ac54a7922bbcc8a87714d
Gerrit-Change-Number: 36570
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Aaron Durbin <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Kyösti Mälkki <[e-mail]>
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Sat, 02 Nov 2019 20:42:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment