Attention is currently required from: Angel Pons. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52670 )
Change subject: mb/dell/optiplex_9010: Always log chosen fan mode ......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/dell/optiplex_9010/sch5545_ec.c:
https://review.coreboot.org/c/coreboot/+/52670/comment/e261ca5d_59ba3561 PS1, Line 659: int fan_speed_full = get_int_option("fan_full_speed", 0);
CB:52672 changes the type of the API, but I can change this here
Uhh, I mean the `int fan_speed_full` -> `unsigned int fan_speed_full` because the CB:52672 changes the function call to the get_uint_option but `int` type remains. Or I am missing something?
-
Michał Żygowski (Code Review)