Attention is currently required from: Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51332 )
Change subject: soc/intel/skylake: detect if IGD is present ......................................................................
Patch Set 2:
(5 comments)
File src/soc/intel/skylake/chip.c:
https://review.coreboot.org/c/coreboot/+/51332/comment/4fa078bf_05c73d26 PS2, Line 536: if (CONFIG(RUN_FSP_GOP) && dev && dev->enabled && \ Avoid unnecessary line continuations
File src/soc/intel/skylake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/51332/comment/a6ec88cc_ae6933eb PS2, Line 118: igd = 0x8086 == pci_read_config16(SA_DEVFN_IGD, PCI_VENDOR_ID); Comparisons should place the constant on the right side of the test
File src/soc/intel/skylake/romstage/systemagent.c:
https://review.coreboot.org/c/coreboot/+/51332/comment/0d4b134e_0539a2c5 PS2, Line 32: if (igd_dev && igd_dev->enabled && pci_read_config16(SA_DEVFN_IGD, PCI_VENDOR_ID) == 0x8086) { line over 96 characters
https://review.coreboot.org/c/coreboot/+/51332/comment/92f7cb21_7ab5b082 PS2, Line 32: if (igd_dev && igd_dev->enabled && pci_read_config16(SA_DEVFN_IGD, PCI_VENDOR_ID) == 0x8086) { braces {} are not necessary for single statement blocks
File src/soc/intel/skylake/systemagent.c:
https://review.coreboot.org/c/coreboot/+/51332/comment/22ed6501_e8e34bfb PS2, Line 49: if (igd_dev && igd_dev->enabled && pci_read_config16(igd_dev, PCI_VENDOR_ID) == 0x8086) line over 96 characters