Change in coreboot[master]: mb/{google/fizz,razer/blade_stealth_kbl}: Add missing include <consol...
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36453 )
Change subject: mb/{google/fizz,razer/blade_stealth_kbl}: Add missing include <console/console.h> ......................................................................
mb/{google/fizz,razer/blade_stealth_kbl}: Add missing include <console/console.h>
Change-Id: Ia4e496d359036591131c1ec0243d64c58823ca63 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/fizz/mainboard.c M src/mainboard/razer/blade_stealth_kbl/romstage.c 2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/36453/1
diff --git a/src/mainboard/google/fizz/mainboard.c b/src/mainboard/google/fizz/mainboard.c index 6a7d452..9397786 100644 --- a/src/mainboard/google/fizz/mainboard.c +++ b/src/mainboard/google/fizz/mainboard.c @@ -16,6 +16,7 @@ #include <arch/acpi.h> #include <baseboard/variants.h> #include <chip.h> +#include <console/console.h> #include <delay.h> #include <device/device.h> #include <ec/ec.h> diff --git a/src/mainboard/razer/blade_stealth_kbl/romstage.c b/src/mainboard/razer/blade_stealth_kbl/romstage.c index 89903ab..445f620 100644 --- a/src/mainboard/razer/blade_stealth_kbl/romstage.c +++ b/src/mainboard/razer/blade_stealth_kbl/romstage.c @@ -17,6 +17,7 @@ */
#include <assert.h> +#include <console/console.h> #include <soc/romstage.h> #include <spd_bin.h> #include "spd/spd.h"
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36453 )
Change subject: mb/{google/fizz,razer/blade_stealth_kbl}: Add missing include <console/console.h> ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36453/1/src/mainboard/google/fizz/m... File src/mainboard/google/fizz/mainboard.c:
https://review.coreboot.org/c/coreboot/+/36453/1/src/mainboard/google/fizz/m... PS1, Line 245: printk it needs #include <console/console.h>
https://review.coreboot.org/c/coreboot/+/36453/1/src/mainboard/razer/blade_s... File src/mainboard/razer/blade_stealth_kbl/romstage.c:
https://review.coreboot.org/c/coreboot/+/36453/1/src/mainboard/razer/blade_s... PS1, Line 42: printk it needs #include <console/console.h>
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36453 )
Change subject: mb/{google/fizz,razer/blade_stealth_kbl}: Add missing include <console/console.h> ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/36453/1/src/mainboard/google/fizz/m... File src/mainboard/google/fizz/mainboard.c:
https://review.coreboot.org/c/coreboot/+/36453/1/src/mainboard/google/fizz/m... PS1, Line 245: printk
it needs #include <console/console. […]
Ack
https://review.coreboot.org/c/coreboot/+/36453/1/src/mainboard/razer/blade_s... File src/mainboard/razer/blade_stealth_kbl/romstage.c:
https://review.coreboot.org/c/coreboot/+/36453/1/src/mainboard/razer/blade_s... PS1, Line 42: printk
it needs #include <console/console. […]
Ack
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36453 )
Change subject: mb/{google/fizz,razer/blade_stealth_kbl}: Add missing include <console/console.h> ......................................................................
mb/{google/fizz,razer/blade_stealth_kbl}: Add missing include <console/console.h>
Change-Id: Ia4e496d359036591131c1ec0243d64c58823ca63 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/36453 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/mainboard/google/fizz/mainboard.c M src/mainboard/razer/blade_stealth_kbl/romstage.c 2 files changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/mainboard/google/fizz/mainboard.c b/src/mainboard/google/fizz/mainboard.c index 6a7d452..9397786 100644 --- a/src/mainboard/google/fizz/mainboard.c +++ b/src/mainboard/google/fizz/mainboard.c @@ -16,6 +16,7 @@ #include <arch/acpi.h> #include <baseboard/variants.h> #include <chip.h> +#include <console/console.h> #include <delay.h> #include <device/device.h> #include <ec/ec.h> diff --git a/src/mainboard/razer/blade_stealth_kbl/romstage.c b/src/mainboard/razer/blade_stealth_kbl/romstage.c index 89903ab..445f620 100644 --- a/src/mainboard/razer/blade_stealth_kbl/romstage.c +++ b/src/mainboard/razer/blade_stealth_kbl/romstage.c @@ -17,6 +17,7 @@ */
#include <assert.h> +#include <console/console.h> #include <soc/romstage.h> #include <spd_bin.h> #include "spd/spd.h"
-
HAOUAS Elyes (Code Review) -
Nico Huber (Code Review)