Attention is currently required from: Jamie Chen, Furquan Shaikh, Kane Chen, Andrey Petrov, Patrick Rudolph. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55153 )
Change subject: soc/intel/apollolake: add 4Gb and 6Gb dram density ......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55153/comment/841b897b_29e3b5eb PS5, Line 9: This patch adds 4gb and 6gb dram density support to APL and GLK. … by adding the appropriate macros.
https://review.coreboot.org/c/coreboot/+/55153/comment/ad5e0b60_e420b1f2 PS5, Line 10: Because ch0_density = 0 is not appropriate to determine whether : the channel is disabled or not, so ch0_enable and ch1_enable are : provided to turn on/off channel respectively. Please do that in a separate commit (ordering it before this one).
File src/soc/intel/apollolake/include/soc/meminit.h:
https://review.coreboot.org/c/coreboot/+/55153/comment/dff7bcdf_532d949b PS5, Line 54: LP4_4Gb_DENSITY, : LP4_6Gb_DENSITY, : LP4_8Gb_DENSITY, : LP4_12Gb_DENSITY, : LP4_16Gb_DENSITY, Unrelated, why not assign the integers to the enums here directly to get rid of the switch statement?
-
Paul Menzel (Code Review)