Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33417 )
Change subject: soc/intel: Add function to set DPR
......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/33417/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/33417/2//COMMIT_MSG@11
PS2, Line 11:
Tested how?
https://review.coreboot.org/c/coreboot/+/33417/2/src/soc/intel/common/block/...
File src/soc/intel/common/block/systemagent/systemagent_early.c:
https://review.coreboot.org/c/coreboot/+/33417/2/src/soc/intel/common/block/...
PS2, Line 235: u32
uint32_t
https://review.coreboot.org/c/coreboot/+/33417/2/src/soc/intel/common/block/...
PS2, Line 238: report
reporting?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33417
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43d2b50a7a6bb41146be99e645cd2ac6a6c9f703
Gerrit-Change-Number: 33417
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Roy Wen
rgzwen@arista.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 18 Jul 2019 12:18:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment