Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Shelley Chen, Tim Van Patten.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79737?usp=email )
Change subject: vendorcode/google/chromeos: Add API to read factory config ......................................................................
Patch Set 5:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79737/comment/c7122f97_01916d70 : PS5, Line 7: API to read factory config
Please make it a statement: […]
Acknowledged
File src/vendorcode/google/chromeos/chromeos.h:
https://review.coreboot.org/c/coreboot/+/79737/comment/9ebde590_4260febf : PS5, Line 31: * For the unprovisioned one, the read will be 0x0.
0 is also returned in the error case?
Acknowledged
File src/vendorcode/google/chromeos/tpm_factory_config.c:
https://review.coreboot.org/c/coreboot/+/79737/comment/e7235644_842b5f83 : PS5, Line 12: printk(BIOS_ERR, "tlcl_lib_init() failed: %#x\n", rc);
As this is an error message, please elaborate for a user reading the log.
sorry, unable to follow.
done
https://review.coreboot.org/c/coreboot/+/79737/comment/16c92220_93fc22a7 : PS5, Line 21: printk(BIOS_ERR, "tlcl_cr50_get_factory_config() failed: %#x\n", rc);
Ditto.
Acknowledged