Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Martin Roth, Felix Held.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69410 )
Change subject: soc/amd/*: Enable override of MAINBOARD_BLOBS_DIR
......................................................................
Patch Set 3:
(3 comments)
File src/soc/amd/common/Kconfig.common:
https://review.coreboot.org/c/coreboot/+/69410/comment/380fab31_c9fdada0
PS2, Line 19:
Nit: get rid of 2nd blank line.
Done
File src/soc/amd/common/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/69410/comment/2d2d7377_6d950309
PS2, Line 2: ifeq ($(CONFIG_SOC_AMD_COMMON),y)
Somewhat unrelated to this patch, but I think this could be extended around most of this file.
See follow-up patch
https://review.coreboot.org/c/coreboot/+/69410/comment/6f1fae28_83475bf7
PS2, Line 49: $(patsubst
There's a macro for this already. […]
Done - thanks for pointing out that macro!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69410
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0702fdb97fbc2c73d97994ab4d5161ff0f467518
Gerrit-Change-Number: 69410
Gerrit-PatchSet: 3
Gerrit-Owner: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 01 Dec 2022 13:52:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-MessageType: comment