View Change

2 comments:

• File src/mainboard/ocp/deltalake/vpd.h:

  • Patch Set #1, Line 37: #define FSPM_MEMREFRESHWATERMARK_DEFAULT 1 /* Default value when the VPD variable is not found */

    I'd just drop the comment

    makes sense

• File src/vendorcode/intel/fsp/fsp2_0/cooperlake_sp/FspmUpd.h:

  • Patch Set #1:

    I'd say the changes to this UPD break the ABI when using the Intel CPX-SP FSP binary

    Yes. When using the Intel (to-be-released) CPX-SP FSP binary, CONFIG_HAVE_FSPM_DIMM_WATERMARK_OPTION can not be set; on the other hand, it has to be set when using FB internal CPX-SP FSP binary.

To view, visit change 46480. To unsubscribe, or for help writing mail filters, visit settings.