Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph, EricR Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56074 ) Change subject: mb/google/brya: Add UsbTcPortEn in devicetree ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File src/mainboard/google/brya/variants/baseboard/devicetree.cb: https://review.coreboot.org/c/coreboot/+/56074/comment/20b5f7b3_9e935189 PS1, Line 62: 0x7 can we have bit wise macro to make the code more readable please ? File src/soc/intel/alderlake/chip.h: https://review.coreboot.org/c/coreboot/+/56074/comment/682a068b_a2005430 PS1, Line 115: /* suggested to add a macro here, similar to https://review.coreboot.org/c/coreboot/+/56074/1/src/soc/intel/alderlake/chi... for TCSS port -- To view, visit https://review.coreboot.org/c/coreboot/+/56074 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe9d3a6d1d73cb37daae4a1ae49ee26abc43635b Gerrit-Change-Number: 56074 Gerrit-PatchSet: 1 Gerrit-Owner: EricR Lai <ericr_lai@compal.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-Attention: Patrick Rudolph <siro@das-labor.org> Gerrit-Attention: EricR Lai <ericr_lai@compal.corp-partner.google.com> Gerrit-Comment-Date: Mon, 05 Jul 2021 09:17:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment