2 comments:
File util/amdfwtool/amdfwtool.c:
Patch Set #1, Line 932: apob_idx = find_bios_entry(AMD_BIOS_APOB);
Why do we perform this lookup prior to checking src field?
Patch Set #1, Line 933: if (!fw_table[i].src) {
so here we only need to check to see if there's also no source specified.
I'm not sure what scenarios this existing code is trying to cover, but I feel like this code is not really very clear. Aren't the scenarios the following?
1. error if src and !size
2. !dest in existing apob? -> apob not used
3. And you want to add !src && !size -> apob not used
if (fw_table[i].type == AMD_BIOS_APOB_NV) {
if (!fw_table[i].size && !fw_table[i].src)
continue; // not used
if (fw_table[i].src && !fw_table[i].size)
error
apob_idx = find_bios_entry();
if (apob_idx < 0 || !fw_table[apob_idx].dest)
continue; // not used
// fall through to the baseline error
}
To view, visit change 44045. To unsubscribe, or for help writing mail filters, visit settings.