Patrick Georgi submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
cpu/intel/car/romstage.c: Drop unused function argument

This is a leftover when migrating to C_ENV_BOOTBLOCK

Change-Id: Ibc610cd15448632dc13d87094853d9b981e2679b
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/55062
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
---
M src/cpu/intel/car/romstage.c
1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/src/cpu/intel/car/romstage.c b/src/cpu/intel/car/romstage.c
index 4b4a4ab..63ddd74 100644
--- a/src/cpu/intel/car/romstage.c
+++ b/src/cpu/intel/car/romstage.c
@@ -16,7 +16,7 @@

static struct postcar_frame early_mtrrs;

-static void romstage_main(unsigned long bist)
+static void romstage_main(void)
{
int i;
const int num_guards = 64;
@@ -58,11 +58,6 @@
/* We do not return here. */
}

-/* We don't carry BIST from bootblock in a good location to read from.
- * Any error should have been reported in bootblock already.
- */
-#define NO_BIST 0
-
asmlinkage void car_stage_entry(void)
{
timestamp_add_now(TS_START_ROMSTAGE);
@@ -70,5 +65,5 @@
/* Assumes the hardware was set up during the bootblock */
console_init();

- romstage_main(NO_BIST);
+ romstage_main();
}

To view, visit change 55062. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc610cd15448632dc13d87094853d9b981e2679b
Gerrit-Change-Number: 55062
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-MessageType: merged