2 comments:
Patch Set #6, Line 107: struct fb_info;
I don't see why exposing the internals helps here. […]
idk, is <framebuffer_info.h> supposed to be a less exposed header than <edid.h>? Looks to me like they were both public APIs. In particular, you can't actually do anything useful with the result of set_vbe_mode_info_valid() unless you #include that one too.
It's just that in general I think our policy in coreboot (and most other projects I've seen) is to just include the header that declares the thing you need, and never forward-declare or double-declare stuff. It just seems messy for no real benefit.
Patch Set #6, Line 172: for (struct fb_info *i = list; i != NULL; i = i->next) {
A later patch will make use of all registered framebuffers.
Ack
To view, visit change 39002. To unsubscribe, or for help writing mail filters, visit settings.