Attention is currently required from: Julius Werner.
3 comments:
File src/arch/arm64/armv8/mmu.c:
Patch Set #1, Line 20: printk(level, tag & MA_MEM_NC ? "non-cacheable | " : " cacheable | ");
This one might be worth wrapping in an ignore block, because the previous text arrangement makes it […]
I agree that the reformat makes it worse here.
File src/arch/arm64/bl31.c:
Patch Set #1, Line 22: .h = {.type = PARAM_EP,
This is kinda ugly. […]
No, the setting aren't that granular. We only have one setting for alignment with the brace.
File src/arch/arm64/romstage.c:
Patch Set #1, Line 12: { /* no-op, for bring-up */
This is also somewhat ugly, I don't suppose there's a flag to keep that closer to what we used to do […]
We can tell it to keep the braces with nothing inside on a single line. The existing coreboot code seems to be undecided about which way to go with this. I like it on the single line too, so I'm happy to change that setting and keep empty braces on the same line.
To view, visit change 80009. To unsubscribe, or for help writing mail filters, visit settings.