Attention is currently required from: Saurabh Mishra.
View Change
1 comment:
Patchset:
Patch Set #15:
May be some scope for improvement for in the code review. There are several wrong (several IDs are wrong, copied from LNL like GFX ID) and incomplete information (There are primarily 3 SOC and this CL only landed the IDs for one SKU w/o clarifying what is thart SKU) landed as part of this CL, which I had to fix using [CL]() and subsequent CLs.
CB:83490 onwards
To view, visit change 81849. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I82f47b6077e28a01f34c59b7e7697323b3d5f990
Gerrit-Change-Number: 81849
Gerrit-PatchSet: 15
Gerrit-Owner: Saurabh Mishra <mishra.saurabh@intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra@intel.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot@gmail.com>
Gerrit-CC: Anil Kumar K <anil.kumar.k@intel.com>
Gerrit-CC: Appukuttan V K <appukuttan.vk@intel.com>
Gerrit-CC: Balaji Manigandan <balaji.manigandan@intel.com>
Gerrit-CC: Bora Guvendik <bora.guvendik@intel.com>
Gerrit-CC: Hannah Williams <hannah.williams@intel.com>
Gerrit-CC: Sanju Jose Thottan <sanjujose.thottan@intel.com>
Gerrit-CC: Wonkyu Kim <wonkyu.kim@intel.com>
Gerrit-CC: sridhar siricilla <siricillasridhar@gmail.com>
Gerrit-Attention: Saurabh Mishra <mishra.saurabh@intel.com>
Gerrit-Comment-Date: Wed, 17 Jul 2024 12:11:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik@google.com>